From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Subject: Re: linux-next: Tree for Jan 7 (rcutorture) Date: Mon, 14 Jan 2013 09:32:08 -0800 Message-ID: <20130114173208.GY3384@linux.vnet.ibm.com> References: <20130107142649.c843e0b711532dc3a631e4cf@canb.auug.org.au> <50EB252C.4010005@infradead.org> <20130107221627.GZ2525@linux.vnet.ibm.com> <20130108095959.98d83d91dbd0e9e1ac023373@canb.auug.org.au> <1357600327.5190.13.camel@gandalf.local.home> <1357605379.5190.15.camel@gandalf.local.home> <20130108035348.GF2525@linux.vnet.ibm.com> <50F43612.8080600@infradead.org> Reply-To: paulmck@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from e7.ny.us.ibm.com ([32.97.182.137]:47094 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756169Ab3ANRkW (ORCPT ); Mon, 14 Jan 2013 12:40:22 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 14 Jan 2013 12:40:21 -0500 Content-Disposition: inline In-Reply-To: <50F43612.8080600@infradead.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: Steven Rostedt , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Jan 14, 2013 at 08:45:06AM -0800, Randy Dunlap wrote: > On 01/07/13 19:53, Paul E. McKenney wrote: > > On Mon, Jan 07, 2013 at 07:36:19PM -0500, Steven Rostedt wrote: > >> On Mon, 2013-01-07 at 18:12 -0500, Steven Rostedt wrote: > >>> On Tue, 2013-01-08 at 09:59 +1100, Stephen Rothwell wrote: > >>>> Hi Paul, > >>>> > >>>> On Mon, 7 Jan 2013 14:16:27 -0800 "Paul E. McKenney" wrote: > >>>>> > >>>>> On Mon, Jan 07, 2013 at 11:42:36AM -0800, Randy Dunlap wrote: > >>>>>> > >>>>>> on i386 or x86_64: > >>>>>> > >>>>>> ERROR: "trace_clock_local" [kernel/rcutorture.ko] undefined! > >>>>> > >>>>> Hello, Randy, > >>>>> > >>>>> Did your build include the following, also pushed to -next in that same > >>>>> batch from -rcu? Including Steven Rostedt on CC for his take. > >>>> > >>>> That commit was certainly in next-20130107. > >>> > >>> Could be bad config dependencies. > >> > >> Paul, > >> > >> You need to also select TRACE_CLOCK if you are going to use it. > > > > Thank you, Steve! > > > > Randy, does the following patch help? > > > > Thanx, Paul > > Hi Paul, > > This patch fixed the Jan. 7 linux-next build errors, but there is > still some similar problem with current linux-next (0114 and late > last week as well). > > ERROR: "trace_clock_local" [kernel/rcutorture.ko] undefined! Ah, my bad... Does the following (rough and untested) patch help? Thanx, Paul ------------------------------------------------------------------------ diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c index cd4c35d..36f0106 100644 --- a/kernel/rcutorture.c +++ b/kernel/rcutorture.c @@ -1047,11 +1047,13 @@ static void rcu_torture_timer(unsigned long unused) static DEFINE_SPINLOCK(rand_lock); struct rcu_torture *p; int pipe_count; - unsigned long long ts; + unsigned long long ts = 0; idx = cur_ops->readlock(); completed = cur_ops->completed(); +#ifdef CONFIG_RCU_TRACE ts = trace_clock_local(); +#endif /* #ifdef CONFIG_RCU_TRACE */ p = rcu_dereference_check(rcu_torture_current, rcu_read_lock_bh_held() || rcu_read_lock_sched_held() ||