From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Sacren Subject: Re: [PATCH -next 1/1] net: skbuff: fix compile error in skb_panic() Date: Wed, 13 Feb 2013 12:43:07 -0700 Message-ID: <20130213194307.GE13159@mail.gmail.com> References: <1360754427-9051-1-git-send-email-james.hogan@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-da0-f47.google.com ([209.85.210.47]:40315 "EHLO mail-da0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753887Ab3BMTnt (ORCPT ); Wed, 13 Feb 2013 14:43:49 -0500 Content-Disposition: inline In-Reply-To: <1360754427-9051-1-git-send-email-james.hogan@imgtec.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: James Hogan Cc: "David S. Miller" , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Jiri Pirko From: James Hogan Date: Wed, 13 Feb 2013 11:20:27 +0000 > > I get the following build error on next-20130213 due to the following > commit: > > commit f05de73bf82fbbc00265c06d12efb7273f7dc54a ("skbuff: create > skb_panic() function and its wrappers"). > > It adds an argument called panic to a function that uses the BUG() macro > which tries to call panic, but the argument masks the panic() function > declaration, resulting in the following error (gcc 4.2.4): > > net/core/skbuff.c In function 'skb_panic': > net/core/skbuff.c +126 : error: called object 'panic' is not a function > > This is fixed by renaming the argument to msg. > > Signed-off-by: James Hogan Thanks, James. I'm sorry I introduced this bug. Shame on me. -- Jean Sacren