From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Xiong Zhou <jencce.kernel@gmail.com>
Cc: linux-next@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] sound/soc/codec : fix build failure in next-201303225
Date: Mon, 25 Mar 2013 12:37:51 +0000 [thread overview]
Message-ID: <20130325123750.GP18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1303252017020.20514@M2420>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Mon, Mar 25, 2013 at 08:34:27PM +0800, Xiong Zhou wrote:
> On Mon, 25 Mar 2013, Mark Brown wrote:
> > No, this isn't a good fix at all - we're moving the array to the header
> > but still exporting it from this file which is not clever at all. The
> > user should be conditional.
> Yes, I agree with you much. Do you have some plan with this array?
> The exproting seems not necesary right now, How about just moving
> the array to the header?
Exactly what I said in my reply...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-03-25 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 11:59 [patch] sound/soc/codec : fix build failure in next-201303225 Xiong Zhou
2013-03-25 12:06 ` Mark Brown
2013-03-25 12:34 ` Xiong Zhou
2013-03-25 12:37 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325123750.GP18316@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jencce.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).