* Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format [not found] ` <20130506095124.GA22041@pd.tnic> @ 2013-07-10 8:12 ` Geert Uytterhoeven 2013-07-10 9:36 ` Borislav Petkov 0 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2013-07-10 8:12 UTC (permalink / raw) To: Borislav Petkov Cc: Kyungsik Lee, Andrew Morton, Michal Marek, linux-kernel@vger.kernel.org, linux-kbuild, the arch/x86 maintainers, CE Linux Developers List, linux-arm-kernel@lists.infradead.org, hyojun.im, chan.jeong, raphael.andy.lee, H. Peter Anvin, Ingo Molnar, Thomas Gleixner, Russell King, Florian Fainelli, Yann Collet, Chanho Min, Linux-Next, uclinux-dist-devel@blackfin.uclinux.org On Mon, May 6, 2013 at 11:51 AM, Borislav Petkov <bp@alien8.de> wrote: > On Mon, May 06, 2013 at 05:42:55PM +0900, Kyungsik Lee wrote: >> LZ4 has been updated with LZ4 Streaming Format specification(v1.3). >> lz4demo is replaced by lz4c. lz4c supports both the new streaming and >> legacy format with -l option. >> >> This patch makes use of lz4c to support legacy format which is >> used for LZ4 De/compression in the linux kernel. >> >> Link: https://code.google.com/p/lz4/source/checkout >> Signed-off-by: Kyungsik Lee <kyungsik.lee@lge.com> >> Cc: "H. Peter Anvin" <hpa@zytor.com> >> Cc: Ingo Molnar <mingo@elte.hu> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Russell King <rmk@arm.linux.org.uk> >> Cc: Borislav Petkov <bp@alien8.de> >> Cc: Florian Fainelli <florian@openwrt.org> >> Cc: Yann Collet <yann.collet.73@gmail.com> >> Cc: Chanho Min <chanho.min@lge.com> >> --- >> scripts/Makefile.lib | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib >> index a0ab6d7..c9bfbb0 100644 >> --- a/scripts/Makefile.lib >> +++ b/scripts/Makefile.lib >> @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \ >> >> quiet_cmd_lz4 = LZ4 $@ >> cmd_lz4 = (cat $(filter-out FORCE,$^) | \ >> - lz4demo -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ >> + lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > > You probably want to check for the presence of lz4c on the system and > bail with an informative message if absent. Yep, x86_64-randconfig (http://kisskb.ellerman.id.au/kisskb/buildresult/9110794/): LZ4 arch/x86/boot/compressed/vmlinux.bin.lz4 /bin/sh: lz4c: command not found Also, several of the blackfin builds started failing due to a compression-related issue, e.g. http://kisskb.ellerman.id.au/kisskb/buildresult/9101322/: UIMAGE arch/blackfin/boot/uImage.lzma Invalid Compression Type - valid names are: none, bzip2, gzip Usage: /usr/local/bin/mkimage -l image -l ==> list image header information /usr/local/bin/mkimage [-x] -A arch -O os -T type -C comp -a addr -e ep -n name -d data_file[:data_file...] image -A ==> set architecture to 'arch' -O ==> set operating system to 'os' -T ==> set image type to 'type' -C ==> set compression type 'comp' -a ==> set load address to 'addr' (hex) -e ==> set entry point to 'ep' (hex) -n ==> set image name to 'name' -d ==> use image data from 'datafile' -x ==> set XIP (execute in place) make[2]: *** [arch/blackfin/boot/uImage.lzma] Error 1 May be unrelated, though. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format 2013-07-10 8:12 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Geert Uytterhoeven @ 2013-07-10 9:36 ` Borislav Petkov 2013-07-10 18:28 ` Markus Trippelsdorf 0 siblings, 1 reply; 6+ messages in thread From: Borislav Petkov @ 2013-07-10 9:36 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Kyungsik Lee, Andrew Morton, Michal Marek, linux-kernel@vger.kernel.org, linux-kbuild, the arch/x86 maintainers, CE Linux Developers List, linux-arm-kernel@lists.infradead.org, hyojun.im, chan.jeong, raphael.andy.lee, H. Peter Anvin, Ingo Molnar, Thomas Gleixner, Russell King, Florian Fainelli, Yann Collet, Chanho Min, Linux-Next, uclinux-dist-devel@blackfin.uclinux.org On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote: > >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > >> index a0ab6d7..c9bfbb0 100644 > >> --- a/scripts/Makefile.lib > >> +++ b/scripts/Makefile.lib > >> @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \ > >> > >> quiet_cmd_lz4 = LZ4 $@ > >> cmd_lz4 = (cat $(filter-out FORCE,$^) | \ > >> - lz4demo -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > >> + lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > > > > You probably want to check for the presence of lz4c on the system and > > bail with an informative message if absent. > > Yep, x86_64-randconfig > (http://kisskb.ellerman.id.au/kisskb/buildresult/9110794/): > > LZ4 arch/x86/boot/compressed/vmlinux.bin.lz4 > /bin/sh: lz4c: command not found Sure, it had to be 2 months and to hit upstream for there still to be no fix. Geez... Anyone reading this and willing to try his skills with an introductory-level patch, feel free to address this. I'll help testing and upstreaming it. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format 2013-07-10 9:36 ` Borislav Petkov @ 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 20:01 ` Borislav Petkov 2013-07-11 4:34 ` Kyungsik Lee 0 siblings, 2 replies; 6+ messages in thread From: Markus Trippelsdorf @ 2013-07-10 18:28 UTC (permalink / raw) To: Borislav Petkov Cc: Geert Uytterhoeven, Kyungsik Lee, Andrew Morton, Michal Marek, linux-kernel@vger.kernel.org, linux-kbuild, the arch/x86 maintainers, CE Linux Developers List, linux-arm-kernel@lists.infradead.org, hyojun.im, chan.jeong, raphael.andy.lee, H. Peter Anvin, Ingo Molnar, Thomas Gleixner, Russell King, Florian Fainelli, Yann Collet, Chanho Min, Linux-Next, uclinux-dist-devel@blackfin.uclinux.org On 2013.07.10 at 11:36 +0200, Borislav Petkov wrote: > On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote: > > >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > > >> index a0ab6d7..c9bfbb0 100644 > > >> --- a/scripts/Makefile.lib > > >> +++ b/scripts/Makefile.lib > > >> @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \ > > >> > > >> quiet_cmd_lz4 = LZ4 $@ > > >> cmd_lz4 = (cat $(filter-out FORCE,$^) | \ > > >> - lz4demo -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > > >> + lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ > > > > > > You probably want to check for the presence of lz4c on the system and > > > bail with an informative message if absent. > > > > Yep, x86_64-randconfig > > (http://kisskb.ellerman.id.au/kisskb/buildresult/9110794/): > > > > LZ4 arch/x86/boot/compressed/vmlinux.bin.lz4 > > /bin/sh: lz4c: command not found > > Sure, it had to be 2 months and to hit upstream for there still to be no > fix. Geez... Well, there's also no hand-holding when lzop is missing for LZO. And the error message is clear enough. No? BTW speaking of introductory-level patches, what about the following one: Now that lz4 kernel compression is available, add *.lz4 to .gitignore diff --git a/.gitignore b/.gitignore index 3b8b9b3..7e9932e 100644 --- a/.gitignore +++ b/.gitignore @@ -29,6 +29,7 @@ modules.builtin *.bz2 *.lzma *.xz +*.lz4 *.lzo *.patch *.gcno -- Markus ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format 2013-07-10 18:28 ` Markus Trippelsdorf @ 2013-07-10 20:01 ` Borislav Petkov 2013-07-11 4:34 ` Kyungsik Lee 1 sibling, 0 replies; 6+ messages in thread From: Borislav Petkov @ 2013-07-10 20:01 UTC (permalink / raw) To: Markus Trippelsdorf Cc: Geert Uytterhoeven, Kyungsik Lee, Andrew Morton, Michal Marek, linux-kernel@vger.kernel.org, linux-kbuild, the arch/x86 maintainers, CE Linux Developers List, linux-arm-kernel@lists.infradead.org, hyojun.im, chan.jeong, raphael.andy.lee, H. Peter Anvin, Ingo Molnar, Thomas Gleixner, Russell King, Florian Fainelli, Yann Collet, Chanho Min, Linux-Next, uclinux-dist-devel@blackfin.uclinux.org On Wed, Jul 10, 2013 at 08:28:15PM +0200, Markus Trippelsdorf wrote: > Well, there's also no hand-holding when lzop is missing for LZO. And > the error message is clear enough. No? Actually, we should error out more gracefully than that. Maybe check for the presence of the executable first and if not, exit out of the build with an informational message that lz4c is not present on the system. Ditto for lzop. Currently, you wait for the whole build to complete just to see that there's no executable at the end. Not nice. > BTW speaking of introductory-level patches, what about the following > one: > > Now that lz4 kernel compression is available, add *.lz4 to .gitignore Yep. That makes sense. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 20:01 ` Borislav Petkov @ 2013-07-11 4:34 ` Kyungsik Lee 2013-07-11 9:46 ` [PATCH] .gitignore: ignore *.lz4 files Markus Trippelsdorf 1 sibling, 1 reply; 6+ messages in thread From: Kyungsik Lee @ 2013-07-11 4:34 UTC (permalink / raw) To: Markus Trippelsdorf Cc: Borislav Petkov, Geert Uytterhoeven, Andrew Morton, Michal Marek, linux-kernel@vger.kernel.org, linux-kbuild, the arch/x86 maintainers, CE Linux Developers List, linux-arm-kernel@lists.infradead.org, hyojun.im, chan.jeong, raphael.andy.lee, H. Peter Anvin, Ingo Molnar, Thomas Gleixner, Russell King, Florian Fainelli, Yann Collet, Chanho Min, Linux-Next, uclinux-dist-devel@blackfin.uclinux.org > > BTW speaking of introductory-level patches, what about the following > one: > > Now that lz4 kernel compression is available, add *.lz4 to .gitignore > > diff --git a/.gitignore b/.gitignore > index 3b8b9b3..7e9932e 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -29,6 +29,7 @@ modules.builtin > *.bz2 > *.lzma > *.xz > +*.lz4 > *.lzo > *.patch > *.gcno > Acked-by: Kyungsik Lee <kyungsik.lee@lge.com> Thanks, Kyungsik ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] .gitignore: ignore *.lz4 files 2013-07-11 4:34 ` Kyungsik Lee @ 2013-07-11 9:46 ` Markus Trippelsdorf 0 siblings, 0 replies; 6+ messages in thread From: Markus Trippelsdorf @ 2013-07-11 9:46 UTC (permalink / raw) To: Kyungsik Lee Cc: Borislav Petkov, Geert Uytterhoeven, Andrew Morton, Michal Marek, linux-kernel@vger.kernel.org, linux-kbuild, the arch/x86 maintainers, CE Linux Developers List, linux-arm-kernel@lists.infradead.org, hyojun.im, chan.jeong, raphael.andy.lee, H. Peter Anvin, Ingo Molnar, Thomas Gleixner, Russell King, Florian Fainelli, Yann Collet, Chanho Min, Linux-Next, uclinux-dist-devel@blackfin.uclinux.org Now that lz4 kernel compression is available, add *.lz4 to .gitignore. Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de> Acked-by: Kyungsik Lee <kyungsik.lee@lge.com> diff --git a/.gitignore b/.gitignore index 3b8b9b3..7e9932e 100644 --- a/.gitignore +++ b/.gitignore @@ -29,6 +29,7 @@ modules.builtin *.bz2 *.lzma *.xz +*.lz4 *.lzo *.patch *.gcno -- Markus ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-11 9:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com>
[not found] ` <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com>
[not found] ` <20130506095124.GA22041@pd.tnic>
2013-07-10 8:12 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Geert Uytterhoeven
2013-07-10 9:36 ` Borislav Petkov
2013-07-10 18:28 ` Markus Trippelsdorf
2013-07-10 20:01 ` Borislav Petkov
2013-07-11 4:34 ` Kyungsik Lee
2013-07-11 9:46 ` [PATCH] .gitignore: ignore *.lz4 files Markus Trippelsdorf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).