linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: rebase of the drivers-x86 tree
@ 2013-07-11  0:04 Stephen Rothwell
       [not found] ` <f7e5023f-0e7e-4da1-a91d-5b9f4fd0db21@email.android.com>
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2013-07-11  0:04 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

Hi Matthew,

Why have you just rebased the drivers-x86 tree
(git://cavan.codon.org.uk/platform-drivers-x86.git#linux-next)?  You have
just invalidated your testing and made it likely that Linus will blast
you if you ask him to pull your tree.  Your whole tree was already based
after v3.10 (i.e. released or rebased after the merge window opened), so
why move it again?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: rebase of the drivers-x86 tree
       [not found] ` <f7e5023f-0e7e-4da1-a91d-5b9f4fd0db21@email.android.com>
@ 2013-07-15  0:13   ` Stephen Rothwell
  2013-07-15 19:17     ` Matthew Garrett
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2013-07-15  0:13 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: linux-next, linux-kernel, Linus

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

Hi Matthew,

On Wed, 10 Jul 2013 20:08:39 -0400 Matthew Garrett <mjg59@srcf.ucam.org> wrote:
>
> Because I noticed that one of the patches changed the permissions on a
> file to 755 and rewrote it. 

That is hardly a reason to rebase your tree.  Just add another commit to
correct the situation.  The tree as it stood would not have affected
anyone's building, running or bisecting.

And why do I now have three versions of your tree?  The one in linux-next
on Friday, the one in linux-next today, and the one you asked Linus to
pull.

I hope you don't have any developers trying to develop stuff based on
your tree :-(

And yes, this is a rhetorical question, just trying to get you to think
about your process.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: rebase of the drivers-x86 tree
  2013-07-15  0:13   ` Stephen Rothwell
@ 2013-07-15 19:17     ` Matthew Garrett
  0 siblings, 0 replies; 3+ messages in thread
From: Matthew Garrett @ 2013-07-15 19:17 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Linus

On Mon, Jul 15, 2013 at 10:13:06AM +1000, Stephen Rothwell wrote:

> That is hardly a reason to rebase your tree.  Just add another commit to
> correct the situation.  The tree as it stood would not have affected
> anyone's building, running or bisecting.

I verified that the only difference before and after rebasing was that 
the file permission was back the way it should be. Why clutter history?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-15 19:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-11  0:04 linux-next: rebase of the drivers-x86 tree Stephen Rothwell
     [not found] ` <f7e5023f-0e7e-4da1-a91d-5b9f4fd0db21@email.android.com>
2013-07-15  0:13   ` Stephen Rothwell
2013-07-15 19:17     ` Matthew Garrett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).