From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Felipe Balbi <balbi@ti.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Roger Quadros <rogerq@ti.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
USB list <linux-usb@vger.kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH] usb: phy: am335x-control: make it compile with
Date: Fri, 16 Aug 2013 17:32:49 +0200 [thread overview]
Message-ID: <20130816153249.GA3570@breakpoint.cc> (raw)
In-Reply-To: <520E0304.5050906@ti.com>
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Randy reported this
|drivers/usb/phy/phy-am335x-control.c:45:3: error: implicit declaration
|of function '__WARN' [-Werror=implicit-function-declaration]
and left it as an excercice to figure out that this happens only with
CONFIG_BUG=n. As a fix I replace it with WARN_ON(). And there is a space
before return so fix this, too.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/usb/phy/phy-am335x-control.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb/phy/phy-am335x-control.c
index 7597545..22cf07d 100644
--- a/drivers/usb/phy/phy-am335x-control.c
+++ b/drivers/usb/phy/phy-am335x-control.c
@@ -42,8 +42,8 @@ static void am335x_phy_power(struct phy_control *phy_ctrl, u32 id, bool on)
reg = AM335X_USB1_CTRL;
break;
default:
- __WARN();
- return;
+ WARN_ON(1);
+ return;
}
val = readl(usb_ctrl->phy_reg + reg);
--
1.8.4.rc2
next prev parent reply other threads:[~2013-08-16 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 6:58 linux-next: Tree for Aug 15 Stephen Rothwell
2013-08-15 17:07 ` linux-next: Tree for Aug 15 (usb/phy/phy-am335x-control.c) Randy Dunlap
2013-08-16 10:46 ` Roger Quadros
2013-08-16 15:32 ` Sebastian Andrzej Siewior [this message]
[not found] ` <20130816153249.GA3570-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2013-08-16 18:00 ` [PATCH] usb: phy: am335x-control: make it compile with Randy Dunlap
2013-08-16 15:40 ` [PATCH] dma: cpp41: make it compile with CONFIG_BUG=n Sebastian Andrzej Siewior
2013-08-19 6:06 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816153249.GA3570@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rogerq@ti.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).