From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Sudeep Dutt <sudeep.dutt@intel.com>,
Dasaratharaman Chandramouli
<dasaratharaman.chandramouli@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Tejun Heo <tj@kernel.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: Build failure after merge of the char-misc tree
Date: Thu, 3 Oct 2013 17:11:34 -0700 [thread overview]
Message-ID: <20131004001134.GA29624@kroah.com> (raw)
In-Reply-To: <20131003235419.GG27287@sirena.org.uk>
On Fri, Oct 04, 2013 at 12:54:19AM +0100, Mark Brown wrote:
> After merging the char-misc tree into -next an x86 allmodconfig build fails
> with:
>
> drivers/misc/mic/host/mic_main.c: In function ‘mic_probe’:
> drivers/misc/mic/host/mic_main.c:320:3: error: too many arguments to function ‘sysfs_get_dirent’
> NULL, "state");
> ^
> In file included from include/linux/kobject.h:21:0,
> from include/linux/module.h:16,
> from drivers/misc/mic/host/mic_main.c:26:
> include/linux/sysfs.h:465:1: note: declared here
> sysfs_get_dirent(struct sysfs_dirent *parent_sd, const unsigned char
> *name)
> ^
> make[4]: *** [drivers/misc/mic/host/mic_main.o] Error 1
>
> caused by an interaction between the addition of the Intel MIC host
> driver and commit 388975cccaaf1 (sysfs: clean up sysfs_get_dirent())
> from the driver-current tree.
>
> I've applied the patch below and can carry it for the time being.
>
> From abbabb4580f45accf74f95aed6fe35b26ae8d009 Mon Sep 17 00:00:00 2001
> From: Mark Brown <broonie@linaro.org>
> Date: Fri, 4 Oct 2013 00:53:01 +0100
> Subject: [PATCH] misc: mic: Update for sysfs_get_dirent() cleanups
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/misc/mic/host/mic_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
That patch looks great, thanks.
greg k-h
prev parent reply other threads:[~2013-10-04 0:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 23:54 Build failure after merge of the char-misc tree Mark Brown
2013-10-04 0:11 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004001134.GA29624@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ashutosh.dixit@intel.com \
--cc=broonie@kernel.org \
--cc=dasaratharaman.chandramouli@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sudeep.dutt@intel.com \
--cc=thierry.reding@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox