From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Chen Gang <gang.chen@asianux.com>,
Peter Zijlstra <peterz@infradead.org>,
Rusty Russell <rusty@rustcorp.com.au>, Robin Holt <holt@sgi.com>,
athorlton@sgi.com, linux-next@vger.kernel.org
Subject: Re: [PATCH] kernel/panic.c: reduce 1 byte usage for print tainted buffer.
Date: Tue, 8 Oct 2013 01:32:19 +0100 [thread overview]
Message-ID: <20131008003219.GC13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20131007172745.4f023e312df95bd94f078ca8@linux-foundation.org>
On Mon, Oct 07, 2013 at 05:27:45PM -0700, Andrew Morton wrote:
> hm, that code is a bit crufty.
>
> - Why is `buf' static? It could be on-stack.
No, it couldn't - check the callers...
next prev parent reply other threads:[~2013-10-08 0:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 15:50 [PATCH] kernel/panic.c: reduce 1 byte usage for print tainted buffer Chen Gang
2013-10-05 15:53 ` Chen Gang
2013-10-07 16:35 ` Alex Thorlton
2013-10-07 21:04 ` Chen Gang
2013-10-08 0:27 ` Andrew Morton
2013-10-08 0:32 ` Al Viro [this message]
2013-10-08 1:10 ` Chen Gang
2013-10-08 1:25 ` Andrew Morton
2013-10-08 1:45 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008003219.GC13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=athorlton@sgi.com \
--cc=gang.chen@asianux.com \
--cc=holt@sgi.com \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).