From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Lindgren <tony@atomide.com>
Subject: Re: linux-next: Tree for Oct 17 (pinctrl-single.c)
Date: Fri, 18 Oct 2013 17:39:26 -0700
Message-ID: <20131019003925.GW15154@atomide.com>
References: <20131018003847.GH2443@sirena.org.uk>
 <5261792C.7030203@infradead.org>
 <CACRpkdaz22N8-9Rg8vR=KGOEL5P6sZm6Hh5PT4Uq381+QmPs7g@mail.gmail.com>
 <20131018233951.GU15154@atomide.com>
 <5261C72D.1090302@infradead.org>
 <20131018234914.GV15154@atomide.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-next-owner@vger.kernel.org>
Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:35380 "EHLO
	mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1753387Ab3JSAjb (ORCPT
	<rfc822;linux-next@vger.kernel.org>); Fri, 18 Oct 2013 20:39:31 -0400
Content-Disposition: inline
In-Reply-To: <20131018234914.GV15154@atomide.com>
Sender: linux-next-owner@vger.kernel.org
List-ID: <linux-next.vger.kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linus Walleij <linus.walleij@linaro.org>, Mark Brown <broonie@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, "pinctl-single.c" <linux-next@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Olof Johansson <olof@lixom.net>

* Tony Lindgren <tony@atomide.com> [131018 16:49]:
> * Randy Dunlap <rdunlap@infradead.org> [131018 16:41]:
> > On 10/18/13 16:39, Tony Lindgren wrote:
> > > 
> > > Looks like we need a little bit of arch specific handling
> > > with the generic IRQ. Fix the issue with an ifdef the
> > > same way as other drivers do.
> > > 
> > > ARM needs things set to IRQF_VALID, which also then sets
> > > noprobe. Others seem to use just irq_set_noprobe().
> > > 
> > > Otherwise we can get:
> > > 
> > > drivers/pinctrl/pinctrl-single.c: In function 'pcs_irqdomain_map':
> > > drivers/pinctrl/pinctrl-single.c:1750:2: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
> > 
> > Did you address this error?  I don't see a fix for it...
> 
> Yes set_irq_flags() is defined for ARM archs in
> arch/arm/include/asm/hw_irq.h which is included from
> include/linux/irq.h as <asm/hw_irq.h>. So the ifdef
> below takes care of that too.
> 
> > > +#ifdef CONFIG_ARM
> > > +	set_irq_flags(irq, IRQF_VALID);
> > > +#else
> > > +	irq_set_noprobe(irq);
> > > +#endif

OK I've sent the pull request and Olof has now pulled the fix
into arm-soc next/dt branch.

Tony