From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: linux-next: build failure after merge of the cgroup tree Date: Wed, 26 Feb 2014 08:44:39 -0500 Message-ID: <20140226134439.GA17302@htj.dyndns.org> References: <20140226174655.b5430a1a2413ddb459dababe@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qc0-f170.google.com ([209.85.216.170]:43614 "EHLO mail-qc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbaBZNom (ORCPT ); Wed, 26 Feb 2014 08:44:42 -0500 Content-Disposition: inline In-Reply-To: <20140226174655.b5430a1a2413ddb459dababe@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: Greg KH , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan On Wed, Feb 26, 2014 at 05:46:55PM +1100, Stephen Rothwell wrote: > Hi Tejun, > > After merging the cgroup tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > kernel/cgroup.c: In function 'cgroup_mount': > kernel/cgroup.c:1572:2: error: too few arguments to function 'kernfs_mount' > dentry = kernfs_mount(fs_type, flags, root->kf_root); > ^ > > Caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs") interacting > with commit fed95bab8d29 ("sysfs: fix namespace refcnt leak") from the > driver-core.current tree. > > I added the following merge fix patch, but it may not be completely > correct, please check. Yes, that should be fine for now. I'll soon pull in Greg's tree into cgroup and apply Li's refcnt fix to cgroup too. Thanks. -- tejun