linux-next: build failure after merge of the mfd-lj tree

linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

Hi Lee,

After merging the mfd-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mfd/tps65218: struct i2c_device_id is 32 bytes.  The last of 1 is:
0x74 0x70 0x73 0x36 0x35 0x32 0x31 0x38 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0xf0 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
FATAL: drivers/mfd/tps65218: struct i2c_device_id is not terminated with a NULL entry!

Caused by commit cc493e30e3a1 ("mfd: tps65218: Add driver for the
TPS65218 PMIC").

I have used the mfd-lj tree from next-20140210 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

Hi Lee,

On Tue, 11 Feb 2014 13:25:52 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the mfd-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/mfd/tps65218: struct i2c_device_id is 32 bytes.  The last of 1 is:
> 0x74 0x70 0x73 0x36 0x35 0x32 0x31 0x38 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0xf0 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
> FATAL: drivers/mfd/tps65218: struct i2c_device_id is not terminated with a NULL entry!
> 
> Caused by commit cc493e30e3a1 ("mfd: tps65218: Add driver for the
> TPS65218 PMIC").

Now that the otherproblem is fixed, I am getting this one again :-(

> I have used the mfd-lj tree from next-20140210 for today.

Again.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the mfd-lj tree

[Lee Jones]

Stephen,

> > After merging the mfd-lj tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/mfd/tps65218: struct i2c_device_id is 32 bytes.  The last of 1 is:
> > 0x74 0x70 0x73 0x36 0x35 0x32 0x31 0x38 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0xf0 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
> > FATAL: drivers/mfd/tps65218: struct i2c_device_id is not terminated with a NULL entry!
> > 
> > Caused by commit cc493e30e3a1 ("mfd: tps65218: Add driver for the
> > TPS65218 PMIC").
> 
> Now that the otherproblem is fixed, I am getting this one again :-(

That's annoying. I thought I'd built all of the new drivers.

> > I have used the mfd-lj tree from next-20140210 for today.
> 
> Again.

Sorry, again.

/me investigates.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the mfd-lj tree

[Lee Jones]

> > After merging the mfd-lj tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/mfd/tps65218: struct i2c_device_id is 32 bytes.  The last of 1 is:
> > 0x74 0x70 0x73 0x36 0x35 0x32 0x31 0x38 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0xf0 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
> > FATAL: drivers/mfd/tps65218: struct i2c_device_id is not terminated with a NULL entry!
> > 
> > Caused by commit cc493e30e3a1 ("mfd: tps65218: Add driver for the
> > TPS65218 PMIC").

-rw-r--r-- 1 lee lee   6320 Mar  4 15:20 tps65218.o

Hmmm... I'm having trouble reproducing the error. My toolchain
doesn't complain about the lack of a terminating entry. I have fixed
the problem and re-pushed the branch though. Would you be kind enough
to re-test it please?

> Now that the otherproblem is fixed, I am getting this one again :-(
> 
> > I have used the mfd-lj tree from next-20140210 for today.
> 
> Again.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

Hi Lee,

On Tue, 4 Mar 2014 16:06:55 +0800 Lee Jones <lee.jones@linaro.org> wrote:
>
> > > After merging the mfd-lj tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > drivers/mfd/tps65218: struct i2c_device_id is 32 bytes.  The last of 1 is:
> > > 0x74 0x70 0x73 0x36 0x35 0x32 0x31 0x38 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0xf0 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
> > > FATAL: drivers/mfd/tps65218: struct i2c_device_id is not terminated with a NULL entry!
> > > 
> > > Caused by commit cc493e30e3a1 ("mfd: tps65218: Add driver for the
> > > TPS65218 PMIC").
> 
> -rw-r--r-- 1 lee lee   6320 Mar  4 15:20 tps65218.o
> 
> Hmmm... I'm having trouble reproducing the error. My toolchain
> doesn't complain about the lack of a terminating entry. I have fixed
> the problem and re-pushed the branch though. Would you be kind enough
> to re-test it please?

I assume that the error comes from some post processing that happens late
in the allmodconfig build process.

You current tree build fine, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Hi Lee,

After merging the mfd-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/mfd/max665x.c:19:0:
include/linux/mfd/max665x-private.h:31:1: error: expected ';', identifier or '(' before 'struct'
 struct max665x_dev {
 ^

Caused by commit e77bb5297293 ("mfd: max665x: Differentiate between
MAX665X devices").  Clearly never built by anyone :-(

I have used the mfd-lj tree from next-20140210 again for today (since the
other version had other problems).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

Hi Lee,

On Fri, 14 Feb 2014 13:42:17 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the mfd-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/mfd/max665x.c:19:0:
> include/linux/mfd/max665x-private.h:31:1: error: expected ';', identifier or '(' before 'struct'
>  struct max665x_dev {
>  ^
> 
> Caused by commit e77bb5297293 ("mfd: max665x: Differentiate between
> MAX665X devices").  Clearly never built by anyone :-(
> 
> I have used the mfd-lj tree from next-20140210 again for today (since the
> other version had other problems).

Still seeing this error.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Hi Lee,

On Mon, 17 Feb 2014 14:14:46 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 14 Feb 2014 13:42:17 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the mfd-lj tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > In file included from drivers/mfd/max665x.c:19:0:
> > include/linux/mfd/max665x-private.h:31:1: error: expected ';', identifier or '(' before 'struct'
> >  struct max665x_dev {
> >  ^
> > 
> > Caused by commit e77bb5297293 ("mfd: max665x: Differentiate between
> > MAX665X devices").  Clearly never built by anyone :-(
> > 
> > I have used the mfd-lj tree from next-20140210 again for today (since the
> > other version had other problems).
> 
> Still seeing this error.

Still ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Hi Lee,

On Thu, 20 Feb 2014 15:05:08 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 17 Feb 2014 14:14:46 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 14 Feb 2014 13:42:17 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the mfd-lj tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > In file included from drivers/mfd/max665x.c:19:0:
> > > include/linux/mfd/max665x-private.h:31:1: error: expected ';', identifier or '(' before 'struct'
> > >  struct max665x_dev {
> > >  ^
> > > 
> > > Caused by commit e77bb5297293 ("mfd: max665x: Differentiate between
> > > MAX665X devices").  Clearly never built by anyone :-(
> > > 
> > > I have used the mfd-lj tree from next-20140210 again for today (since the
> > > other version had other problems).
> > 
> > Still seeing this error.
> 
> Still ...

Ping ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

Hi Lee,

On Tue, 25 Feb 2014 14:32:46 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 20 Feb 2014 15:05:08 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 17 Feb 2014 14:14:46 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > On Fri, 14 Feb 2014 13:42:17 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the mfd-lj tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > > 
> > > > In file included from drivers/mfd/max665x.c:19:0:
> > > > include/linux/mfd/max665x-private.h:31:1: error: expected ';', identifier or '(' before 'struct'
> > > >  struct max665x_dev {
> > > >  ^
> > > > 
> > > > Caused by commit e77bb5297293 ("mfd: max665x: Differentiate between
> > > > MAX665X devices").  Clearly never built by anyone :-(
> > > > 
> > > > I have used the mfd-lj tree from next-20140210 again for today (since the
> > > > other version had other problems).
> > > 
> > > Still seeing this error.
> > 
> > Still ...
> 
> Ping ...

I am still seeing this error which means that I am still using the
version of your tree from next-20140210 i.e. Feb 10.  It is a bit
disappointing that his has not been fixed in such a long time even though
there have been other updates to your tree which means that those other
changes have received no exposure in linux-next.  It is a trivial error,
but it does indicate that noone ever build tested that particular commit.

(this is now commit 2fc7e7d25bee in your tree since it was rewritten but
not fixed on Feb 14.)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the mfd-lj tree

[Lee Jones]

Hi Stephen,

> > > > > After merging the mfd-lj tree, today's linux-next build (x86_64
> > > > > allmodconfig) failed like this:
> > > > > 
> > > > > In file included from drivers/mfd/max665x.c:19:0:
> > > > > include/linux/mfd/max665x-private.h:31:1: error: expected ';', identifier or '(' before 'struct'
> > > > >  struct max665x_dev {
> > > > >  ^
> > > > > 
> > > > > Caused by commit e77bb5297293 ("mfd: max665x: Differentiate between
> > > > > MAX665X devices").  Clearly never built by anyone :-(
> > > > > 
> > > > > I have used the mfd-lj tree from next-20140210 again for today (since the
> > > > > other version had other problems).
> > > > 
> > > > Still seeing this error.
> > > 
> > > Still ...
> > 
> > Ping ...
> 
> I am still seeing this error which means that I am still using the
> version of your tree from next-20140210 i.e. Feb 10.  It is a bit
> disappointing that his has not been fixed in such a long time even though
> there have been other updates to your tree which means that those other
> changes have received no exposure in linux-next.  It is a trivial error,
> but it does indicate that noone ever build tested that particular commit.
> 
> (this is now commit 2fc7e7d25bee in your tree since it was rewritten but
> not fixed on Feb 14.)

Sorry about all this. Your mails are being filtered into an unused
mailbox for a currently unknown reason. I will investigate this
immediately. It was a mistake to push this patch, I will rectify right
away.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi Lee,

On Mon, 3 Mar 2014 15:23:31 +0800 Lee Jones <lee.jones@linaro.org> wrote:
>
> Sorry about all this. Your mails are being filtered into an unused
> mailbox for a currently unknown reason. I will investigate this
> immediately. It was a mistake to push this patch, I will rectify right
> away.

I was beginning to wonder if I had been spam binned :-)

Thanks for taking care of this.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

Hi Lee,

After merging the mfd-lj tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/mfd/db8500-prcmu.c: In function 'round_armss_rate':
drivers/mfd/db8500-prcmu.c:1744:2: error: implicit declaration of function 'cpufreq_for_each_entry' [-Werror=implicit-function-declaration]
drivers/mfd/db8500-prcmu.c:1744:52: error: expected ';' before '{' token
drivers/mfd/db8500-prcmu.c:1738:7: warning: unused variable 'freq' [-Wunused-variable]
drivers/mfd/db8500-prcmu.c:1752:1: warning: no return statement in function returning non-void [-Wreturn-type]
drivers/mfd/db8500-prcmu.c: In function 'set_armss_rate':
drivers/mfd/db8500-prcmu.c:1895:3: error: expected ';' before 'if'

Caused by commit 2eb3cfd03d60 ("mfd: db8500-prcmu: Use
cpufreq_for_each_entry macro for iteration").

I have used the mfd-lj tree from next-20140423 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

Hi Lee,

After merging the mfd-lj tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/mfd/stmpe.c: In function 'stmpe_irq_init':
drivers/mfd/stmpe.c:1000:15: error: 'struct stmpe' has no member named 'irq_base'
   base = stmpe->irq_base;
               ^

Caused by commit 3ba1d516d5fe ("mfd: stmpe: root out static GPIO and
IRQ assignments").

This is exactly the same error and commit I reported against the gpio
tree on Friday.  Why has it come back?

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the mfd-lj tree

[Linus Walleij]

On Tue, May 20, 2014 at 10:01 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> drivers/mfd/stmpe.c: In function 'stmpe_irq_init':
> drivers/mfd/stmpe.c:1000:15: error: 'struct stmpe' has no member named 'irq_base'
>    base = stmpe->irq_base;
>                ^
>
> Caused by commit 3ba1d516d5fe ("mfd: stmpe: root out static GPIO and
> IRQ assignments").

Some mishap in merging these patches I think. I don't have that
line in my branch with the latest patches, I'll get the proper
versions to Lee somehow.

> This is exactly the same error and commit I reported against the gpio
> tree on Friday.  Why has it come back?

It is supposed to come through both trees but I took the branch
out of GPIO after the initial troubles, but it seems to remain in
MFD.

Yours,
Linus Walleij

linux-next: build failure after merge of the mfd-lj tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Hi Lee,

After merging the mfd-lj tree, today's linux-next build (powerpc
allyesconfig) failed like this:


drivers/gpio/gpio-crystalcove.c: In function 'crystalcove_gpio_dbg_show':
drivers/gpio/gpio-crystalcove.c:286:3: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]
   seq_printf(s, " gpio-%-2d %s %s %s %s ctlo=%2x,%s %s %s\n",
   ^

Caused by commit 104fb1d5153c ("gpio: Add support for Intel Crystal
Cove PMIC").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]