* linux-next: build failure after merge of the drm-intel tree
@ 2014-03-19 0:53 Stephen Rothwell
2014-03-19 1:18 ` Steven Rostedt
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2014-03-19 0:53 UTC (permalink / raw)
To: Daniel Vetter, intel-gfx, dri-devel
Cc: linux-next, linux-kernel, Steven Rostedt
[-- Attachment #1: Type: text/plain, Size: 2838 bytes --]
Hi all,
After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from include/trace/define_trace.h:90:0,
from drivers/gpu/drm/i915/i915_trace.h:520,
from drivers/gpu/drm/i915/i915_trace_points.c:12:
drivers/gpu/drm/i915/./i915_trace.h: In function 'ftrace_raw_event_i915_gem_evict_vm':
drivers/gpu/drm/i915/./i915_trace.h:246:22: error: 'dev' undeclared (first use in this function)
__entry->dev = dev->primary->index;
^
include/trace/ftrace.h:574:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^
include/trace/ftrace.h:36:9: note: in expansion of macro 'PARAMS'
PARAMS(assign), \
^
drivers/gpu/drm/i915/./i915_trace.h:236:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(i915_gem_evict_vm,
^
drivers/gpu/drm/i915/./i915_trace.h:245:6: note: in expansion of macro 'TP_fast_assign'
TP_fast_assign(
^
drivers/gpu/drm/i915/./i915_trace.h:246:22: note: each undeclared identifier is reported only once for each function it appears in
__entry->dev = dev->primary->index;
^
include/trace/ftrace.h:574:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^
include/trace/ftrace.h:36:9: note: in expansion of macro 'PARAMS'
PARAMS(assign), \
^
drivers/gpu/drm/i915/./i915_trace.h:236:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(i915_gem_evict_vm,
^
drivers/gpu/drm/i915/./i915_trace.h:245:6: note: in expansion of macro 'TP_fast_assign'
TP_fast_assign(
^
In file included from include/trace/define_trace.h:90:0,
from drivers/gpu/drm/i915/i915_trace.h:520,
from drivers/gpu/drm/i915/i915_trace_points.c:12:
drivers/gpu/drm/i915/./i915_trace.h: In function 'perf_trace_i915_gem_evict_vm':
drivers/gpu/drm/i915/./i915_trace.h:246:22: error: 'dev' undeclared (first use in this function)
__entry->dev = dev->primary->index;
^
include/trace/ftrace.h:708:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
{ assign; } \
^
include/trace/ftrace.h:36:9: note: in expansion of macro 'PARAMS'
PARAMS(assign), \
^
drivers/gpu/drm/i915/./i915_trace.h:236:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(i915_gem_evict_vm,
^
drivers/gpu/drm/i915/./i915_trace.h:245:6: note: in expansion of macro 'TP_fast_assign'
TP_fast_assign(
^
Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers
from ring buffer in evict event").
I have used the drm-intel tree from next-20140318 for today.
--
Cheers,
Stephen Rothwell <sfr@canb.auug.org.au>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: linux-next: build failure after merge of the drm-intel tree
2014-03-19 0:53 linux-next: build failure after merge of the drm-intel tree Stephen Rothwell
@ 2014-03-19 1:18 ` Steven Rostedt
2014-03-19 1:54 ` [Intel-gfx] " Ben Widawsky
0 siblings, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2014-03-19 1:18 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Daniel Vetter, intel-gfx, linux-next, linux-kernel, dri-devel
On Wed, 19 Mar 2014 11:53:50 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers
> from ring buffer in evict event").
>
> I have used the drm-intel tree from next-20140318 for today.
>
Bah! I'm still suffering from jet lag (just came back from Linux-Tage
in Chemnitz).
The next time I compile test a patch for a module, I'll make sure I have
that module's config option set :-( The woe of using localmodconfig. I
should have picked the box with the i915. :-/
Below is the fix. I'll repost a v2 of the original patch.
Sorry about that.
-- Steve
diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
index f3e8a90..783ae08 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -243,7 +243,7 @@ TRACE_EVENT(i915_gem_evict_vm,
),
TP_fast_assign(
- __entry->dev = dev->primary->index;
+ __entry->dev = vm->dev->primary->index;
__entry->vm = vm;
),
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree
2014-03-19 1:18 ` Steven Rostedt
@ 2014-03-19 1:54 ` Ben Widawsky
2014-03-19 7:20 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Ben Widawsky @ 2014-03-19 1:54 UTC (permalink / raw)
To: Steven Rostedt
Cc: Stephen Rothwell, Daniel Vetter, intel-gfx, linux-kernel,
dri-devel, linux-next
On Tue, Mar 18, 2014 at 09:18:42PM -0400, Steven Rostedt wrote:
> On Wed, 19 Mar 2014 11:53:50 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
>
> > Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers
> > from ring buffer in evict event").
> >
> > I have used the drm-intel tree from next-20140318 for today.
> >
>
> Bah! I'm still suffering from jet lag (just came back from Linux-Tage
> in Chemnitz).
>
> The next time I compile test a patch for a module, I'll make sure I have
> that module's config option set :-( The woe of using localmodconfig. I
> should have picked the box with the i915. :-/
>
> Below is the fix. I'll repost a v2 of the original patch.
>
> Sorry about that.
>
I was about to send out the same fix when I saw this.
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> -- Steve
>
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index f3e8a90..783ae08 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -243,7 +243,7 @@ TRACE_EVENT(i915_gem_evict_vm,
> ),
>
> TP_fast_assign(
> - __entry->dev = dev->primary->index;
> + __entry->dev = vm->dev->primary->index;
> __entry->vm = vm;
> ),
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ben Widawsky, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree
2014-03-19 1:54 ` [Intel-gfx] " Ben Widawsky
@ 2014-03-19 7:20 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2014-03-19 7:20 UTC (permalink / raw)
To: Ben Widawsky
Cc: Stephen Rothwell, intel-gfx, Linux Kernel Mailing List, dri-devel,
linux-next, Steven Rostedt
On Wed, Mar 19, 2014 at 2:54 AM, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Tue, Mar 18, 2014 at 09:18:42PM -0400, Steven Rostedt wrote:
>> On Wed, 19 Mar 2014 11:53:50 +1100
>> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>>
>> > Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers
>> > from ring buffer in evict event").
>> >
>> > I have used the drm-intel tree from next-20140318 for today.
>> >
>>
>> Bah! I'm still suffering from jet lag (just came back from Linux-Tage
>> in Chemnitz).
>>
>> The next time I compile test a patch for a module, I'll make sure I have
>> that module's config option set :-( The woe of using localmodconfig. I
>> should have picked the box with the i915. :-/
>>
>> Below is the fix. I'll repost a v2 of the original patch.
>>
>> Sorry about that.
>>
>
> I was about to send out the same fix when I saw this.
>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
Just fixed this this morning before starting to read mail - my
apologies the mess me pushing out a patch yesterday right before
rushing out caused, really shouldn't be doing that ;-)
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: build failure after merge of the drm-intel tree
@ 2016-05-23 2:24 Stephen Rothwell
2016-05-23 8:55 ` [Intel-gfx] " Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2016-05-23 2:24 UTC (permalink / raw)
To: Daniel Vetter, intel-gfx, dri-devel; +Cc: linux-next, linux-kernel
Hi all,
After merging the drm-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from drivers/gpu/drm/i915/i915_trace.h:10:0,
from drivers/gpu/drm/i915/i915_drv.h:2735,
from drivers/gpu/drm/i915/i915_drv.c:34:
drivers/gpu/drm/i915/intel_drv.h:36:41: fatal error: drm/drm_dp_dual_mode_helper.h: No such file or directory
Caused by commit
8d87410a019f ("drm/i915: Respect DP++ adaptor TMDS clock limit")
I have used the drm-intel tree from next-20160520 for today.
--
Cheers,
Stephen Rothwell
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree
2016-05-23 2:24 Stephen Rothwell
@ 2016-05-23 8:55 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2016-05-23 8:55 UTC (permalink / raw)
To: Stephen Rothwell, Daniel Vetter, intel-gfx, dri-devel
Cc: linux-next, linux-kernel
On Mon, 23 May 2016, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the drm-intel tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from drivers/gpu/drm/i915/i915_trace.h:10:0,
> from drivers/gpu/drm/i915/i915_drv.h:2735,
> from drivers/gpu/drm/i915/i915_drv.c:34:
> drivers/gpu/drm/i915/intel_drv.h:36:41: fatal error: drm/drm_dp_dual_mode_helper.h: No such file or directory
>
> Caused by commit
>
> 8d87410a019f ("drm/i915: Respect DP++ adaptor TMDS clock limit")
>
> I have used the drm-intel tree from next-20160520 for today.
Hi Stephen, my bad, should be fixed now, sorry for the trouble.
(Note to self, don't even dream of doing this stuff when you're out
sick. Try to remember there was a reason you were out sick and not at
the office in the first place...)
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-23 8:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-19 0:53 linux-next: build failure after merge of the drm-intel tree Stephen Rothwell
2014-03-19 1:18 ` Steven Rostedt
2014-03-19 1:54 ` [Intel-gfx] " Ben Widawsky
2014-03-19 7:20 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2016-05-23 2:24 Stephen Rothwell
2016-05-23 8:55 ` [Intel-gfx] " Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).