From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michele Curti <michele.curti@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
abbotti@mev.co.uk, linux-next@vger.kernel.org,
chase.southwood@yahoo.com
Subject: Re: [PATCH] staging: comedi: declare das6402_boards as static
Date: Thu, 10 Apr 2014 17:06:53 +0300 [thread overview]
Message-ID: <20140410140653.GG26890@mwanda> (raw)
In-Reply-To: <20140410135447.GA11137@powerline.azcom-win.it>
On Thu, Apr 10, 2014 at 03:54:47PM +0200, Michele Curti wrote:
> Hi,
> das6402_boards array seems to be used in das6402.c only, so declare it
> as static.
>
> This patch applies to linux-next next-20140410.
>
> Regards,
> Michele
>
The patch is fine, but you have too much fluff in the changelog. We
just apply patches automatically by saving the raw email as text
(including headers and everything) the we do a
`cat raw_email.txt | git am`.
Your changelog is all "Hello, how are you? blah blah blah. Best
wishes, etc.". It should just say:
das6402_boards array is used in das6402.c only, so declare it as static.
Signed-off-by ...
You can put the "This patch applies to linux-next next-20140410" under
the --- cut off line so that we're aware but it doesn't get saved in the
log. For staging it doesn't really matter, because either the patch
applies to linux-next or we'll ask you to redo it.
Please send a v2 with a terser changelog.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-10 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 13:54 [PATCH] staging: comedi: declare das6402_boards as static Michele Curti
2014-04-10 14:06 ` Dan Carpenter [this message]
2014-04-10 14:38 ` [PATCH v2] " Michele Curti
2014-04-10 14:45 ` Dan Carpenter
2014-04-10 14:51 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410140653.GG26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=chase.southwood@yahoo.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-next@vger.kernel.org \
--cc=michele.curti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).