* [PATCH] staging: comedi: declare das6402_boards as static
@ 2014-04-10 13:54 Michele Curti
2014-04-10 14:06 ` Dan Carpenter
2014-04-10 14:38 ` [PATCH v2] " Michele Curti
0 siblings, 2 replies; 5+ messages in thread
From: Michele Curti @ 2014-04-10 13:54 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh, chase.southwood, devel, linux-next
Hi,
das6402_boards array seems to be used in das6402.c only, so declare it
as static.
This patch applies to linux-next next-20140410.
Regards,
Michele
Signed-off-by: Michele Curti <michele.curti@gmail.com>
---
drivers/staging/comedi/drivers/das6402.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das6402.c b/drivers/staging/comedi/drivers/das6402.c
index e0cfb6c..d18eea6 100644
--- a/drivers/staging/comedi/drivers/das6402.c
+++ b/drivers/staging/comedi/drivers/das6402.c
@@ -125,7 +125,7 @@ struct das6402_boardinfo {
unsigned int maxdata;
};
-struct das6402_boardinfo das6402_boards[] = {
+static struct das6402_boardinfo das6402_boards[] = {
{
.name = "das6402-12",
.maxdata = 0x0fff,
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: comedi: declare das6402_boards as static
2014-04-10 13:54 [PATCH] staging: comedi: declare das6402_boards as static Michele Curti
@ 2014-04-10 14:06 ` Dan Carpenter
2014-04-10 14:38 ` [PATCH v2] " Michele Curti
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-04-10 14:06 UTC (permalink / raw)
To: Michele Curti; +Cc: devel, gregkh, abbotti, linux-next, chase.southwood
On Thu, Apr 10, 2014 at 03:54:47PM +0200, Michele Curti wrote:
> Hi,
> das6402_boards array seems to be used in das6402.c only, so declare it
> as static.
>
> This patch applies to linux-next next-20140410.
>
> Regards,
> Michele
>
The patch is fine, but you have too much fluff in the changelog. We
just apply patches automatically by saving the raw email as text
(including headers and everything) the we do a
`cat raw_email.txt | git am`.
Your changelog is all "Hello, how are you? blah blah blah. Best
wishes, etc.". It should just say:
das6402_boards array is used in das6402.c only, so declare it as static.
Signed-off-by ...
You can put the "This patch applies to linux-next next-20140410" under
the --- cut off line so that we're aware but it doesn't get saved in the
log. For staging it doesn't really matter, because either the patch
applies to linux-next or we'll ask you to redo it.
Please send a v2 with a terser changelog.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] staging: comedi: declare das6402_boards as static
2014-04-10 13:54 [PATCH] staging: comedi: declare das6402_boards as static Michele Curti
2014-04-10 14:06 ` Dan Carpenter
@ 2014-04-10 14:38 ` Michele Curti
2014-04-10 14:45 ` Dan Carpenter
2014-04-10 14:51 ` Ian Abbott
1 sibling, 2 replies; 5+ messages in thread
From: Michele Curti @ 2014-04-10 14:38 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh, chase.southwood, devel, linux-next
das6402_boards array is used in das6402.c only, so declare it as static.
Signed-off-by: Michele Curti <michele.curti@gmail.com>
---
drivers/staging/comedi/drivers/das6402.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das6402.c b/drivers/staging/comedi/drivers/das6402.c
index e0cfb6c..d18eea6 100644
--- a/drivers/staging/comedi/drivers/das6402.c
+++ b/drivers/staging/comedi/drivers/das6402.c
@@ -125,7 +125,7 @@ struct das6402_boardinfo {
unsigned int maxdata;
};
-struct das6402_boardinfo das6402_boards[] = {
+static struct das6402_boardinfo das6402_boards[] = {
{
.name = "das6402-12",
.maxdata = 0x0fff,
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] staging: comedi: declare das6402_boards as static
2014-04-10 14:38 ` [PATCH v2] " Michele Curti
@ 2014-04-10 14:45 ` Dan Carpenter
2014-04-10 14:51 ` Ian Abbott
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-04-10 14:45 UTC (permalink / raw)
To: Michele Curti; +Cc: devel, gregkh, abbotti, linux-next, chase.southwood
On Thu, Apr 10, 2014 at 04:38:00PM +0200, Michele Curti wrote:
>
> das6402_boards array is used in das6402.c only, so declare it as static.
>
> Signed-off-by: Michele Curti <michele.curti@gmail.com>
Looks good.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: comedi: declare das6402_boards as static
2014-04-10 14:38 ` [PATCH v2] " Michele Curti
2014-04-10 14:45 ` Dan Carpenter
@ 2014-04-10 14:51 ` Ian Abbott
1 sibling, 0 replies; 5+ messages in thread
From: Ian Abbott @ 2014-04-10 14:51 UTC (permalink / raw)
To: Michele Curti, hsweeten, gregkh, chase.southwood, devel,
linux-next
On 2014-04-10 15:38, Michele Curti wrote:
>
> das6402_boards array is used in das6402.c only, so declare it as static.
>
> Signed-off-by: Michele Curti <michele.curti@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-04-10 14:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-10 13:54 [PATCH] staging: comedi: declare das6402_boards as static Michele Curti
2014-04-10 14:06 ` Dan Carpenter
2014-04-10 14:38 ` [PATCH v2] " Michele Curti
2014-04-10 14:45 ` Dan Carpenter
2014-04-10 14:51 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).