From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Vincent Stehlé" <vincent.stehle@laposte.net>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [PATCH linux-next] DRM: Armada: update dma_buf_export use
Date: Sun, 25 May 2014 23:54:35 +0100 [thread overview]
Message-ID: <20140525225435.GZ3693@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CANq1E4QdGeHeuCu9LvPkbGZX5C+ax4fWVqq4kJ5wMUBx5uWZrQ@mail.gmail.com>
On Sun, May 25, 2014 at 02:08:48PM +0200, David Herrmann wrote:
> Hi
>
> On Sat, May 24, 2014 at 11:05 PM, Vincent Stehlé
> <vincent.stehle@laposte.net> wrote:
> > The dma_buf_export function was updated in commit 4bcec44ffaf9 'dma-buf: use
> > reservation objects' to take a reservation object parameter; update Armada
> > export method accordingly.
> >
> > This fixes the following compilation error:
> >
> > drivers/gpu/drm/armada/armada_gem.c: In function ‘armada_gem_prime_export’:
> > drivers/gpu/drm/armada/armada_gem.c:544:16: error: macro "dma_buf_export" requires 5 arguments, but only 4 given
> >
> > Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Airlied, can you merge this please? Thanks.
> Thanks
> David
>
> > ---
> >
> > Hi,
> >
> > This can be seen with e.g. linux next-20140523 and arm allmodconfig.
> >
> > Best regards,
> >
> > V.
> >
> > drivers/gpu/drm/armada/armada_gem.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
> > index 887816f..7adb0c3 100644
> > --- a/drivers/gpu/drm/armada/armada_gem.c
> > +++ b/drivers/gpu/drm/armada/armada_gem.c
> > @@ -541,7 +541,7 @@ armada_gem_prime_export(struct drm_device *dev, struct drm_gem_object *obj,
> > int flags)
> > {
> > return dma_buf_export(obj, &armada_gem_prime_dmabuf_ops, obj->size,
> > - O_RDWR);
> > + O_RDWR, NULL);
> > }
> >
> > struct drm_gem_object *
> > --
> > 2.0.0.rc2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-05-25 22:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 21:05 [PATCH linux-next] DRM: Armada: update dma_buf_export use Vincent Stehlé
2014-05-25 12:08 ` David Herrmann
2014-05-25 22:54 ` Russell King - ARM Linux [this message]
2014-05-25 23:06 ` Stephen Rothwell
2014-05-27 5:52 ` Dave Airlie
2014-05-27 6:22 ` Stephen Rothwell
2014-05-27 11:41 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140525225435.GZ3693@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox