public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xiubo Li <Li.Xiubo@freescale.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: linux-next: build failure after merge of the devicetree tree
Date: Mon, 26 May 2014 15:05:57 +1000	[thread overview]
Message-ID: <20140526150557.219ea08f@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]

Hi Grant,

After merging the devicetree tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/of/base.c: In function 'of_update_property':
drivers/of/base.c:1906:10: error: 'found' undeclared (first use in this function)
   return found ? 0 : -ENODEV;
          ^

Caused by a bad automatic merge resolution between commits 582da6527da3
("of: make of_update_property() usable earlier in the boot process")
(merged into Linus' tree between v3.15-rc4 and rc5) and 947fdaad0627
("of: fix race between search and remove in of_update_property()") from
the devicetree tree.

I have added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 26 May 2014 14:50:40 +1000
Subject: [PATCH] of: fix bad merge of drivers/of/base.c

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/of/base.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 395ee2b3146d..03e7fc6c93e8 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1901,10 +1901,6 @@ int of_update_property(struct device_node *np, struct property *newprop)
 	if (!of_kset)
 		return 0;
 
-	/* At early boot, bail out and defer setup to of_init() */
-	if (!of_kset)
-		return found ? 0 : -ENODEV;
-
 	/* Update the sysfs attribute */
 	if (oldprop)
 		sysfs_remove_bin_file(&np->kobj, &oldprop->attr);
-- 
2.0.0.rc4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2014-05-26  5:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26  5:05 Stephen Rothwell [this message]
2014-05-26  7:22 ` linux-next: build failure after merge of the devicetree tree Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2025-11-17  4:13 Stephen Rothwell
2023-12-11  5:05 Stephen Rothwell
2023-12-12  9:04 ` Sibi Sankar
2024-01-19  0:58 ` Stephen Rothwell
2024-01-19 14:07   ` Rob Herring
2023-12-08  2:51 Stephen Rothwell
2023-12-08  7:34 ` Krzysztof Kozlowski
2023-12-07  1:57 Stephen Rothwell
2023-12-07 15:11 ` Rob Herring
2023-12-07 20:58   ` Stephen Rothwell
2023-12-07 22:05     ` Rob Herring
2023-12-08  3:11       ` Stephen Rothwell
2023-04-11  2:28 Stephen Rothwell
2011-10-05  5:24 Stephen Rothwell
2011-10-05  5:54 ` Grant Likely
2010-07-30  3:57 Stephen Rothwell
2010-07-30  6:11 ` Grant Likely
2010-07-15  2:15 Stephen Rothwell
2010-07-15  6:06 ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140526150557.219ea08f@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=Li.Xiubo@freescale.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox