* [PATCH linux-next] imx-drm: imx-tve: remove unused variable
@ 2014-05-25 21:54 Vincent Stehlé
2014-05-25 22:12 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Vincent Stehlé @ 2014-05-25 21:54 UTC (permalink / raw)
To: devel, linux-kernel, linux-next
Cc: Vincent Stehlé, Andrzej Hajda, Daniel Vetter,
Greg Kroah-Hartman
Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret
unused; remove it.
This fixes the following compilation warning:
drivers/staging/imx-drm/imx-tve.c: In function ‘imx_tve_connector_mode_valid’:
drivers/staging/imx-drm/imx-tve.c:252:6: warning: unused variable ‘ret’ [-Wunused-variable]
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Hi,
This can be seen with e.g. linux next-20140523 and arm allmodconfig.
Best regards,
V.
drivers/staging/imx-drm/imx-tve.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c
index 3e8b0a1..4caef2b1 100644
--- a/drivers/staging/imx-drm/imx-tve.c
+++ b/drivers/staging/imx-drm/imx-tve.c
@@ -249,7 +249,6 @@ static int imx_tve_connector_mode_valid(struct drm_connector *connector,
{
struct imx_tve *tve = con_to_tve(connector);
unsigned long rate;
- int ret;
/* pixel clock with 2x oversampling */
rate = clk_round_rate(tve->clk, 2000UL * mode->clock) / 2000;
--
2.0.0.rc2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] imx-drm: imx-tve: remove unused variable
2014-05-25 21:54 [PATCH linux-next] imx-drm: imx-tve: remove unused variable Vincent Stehlé
@ 2014-05-25 22:12 ` Greg Kroah-Hartman
2014-05-25 23:12 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2014-05-25 22:12 UTC (permalink / raw)
To: Vincent Stehlé
Cc: devel, Daniel Vetter, linux-next, linux-kernel, Andrzej Hajda
On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote:
> Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret
> unused; remove it.
>
> This fixes the following compilation warning:
>
> drivers/staging/imx-drm/imx-tve.c: In function ‘imx_tve_connector_mode_valid’:
> drivers/staging/imx-drm/imx-tve.c:252:6: warning: unused variable ‘ret’ [-Wunused-variable]
It doesn't apply to my tree :(
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] imx-drm: imx-tve: remove unused variable
2014-05-25 22:12 ` Greg Kroah-Hartman
@ 2014-05-25 23:12 ` Stephen Rothwell
2014-05-27 12:56 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2014-05-25 23:12 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Vincent Stehlé, devel, linux-kernel, linux-next,
Daniel Vetter, Andrzej Hajda, Dave Airlie
[-- Attachment #1: Type: text/plain, Size: 2275 bytes --]
Hi all,
On Sun, 25 May 2014 15:12:35 -0700 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote:
> > Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret
> > unused; remove it.
> >
> > This fixes the following compilation warning:
> >
> > drivers/staging/imx-drm/imx-tve.c: In function ‘imx_tve_connector_mode_valid’:
> > drivers/staging/imx-drm/imx-tve.c:252:6: warning: unused variable ‘ret’ [-Wunused-variable]
>
> It doesn't apply to my tree :(
Yeah, commit f9b0e251dfbf 'drm: make mode_valid callback optional' is
in the drm tree, so this patch needs to go to Dave Airlie (cc'd).
Though Daniel Vetter may want to send it on.
For Dave's benefit, here is the patch again:
From: Vincent Stehlé <vincent.stehle@laposte.net>
Subject: [PATCH linux-next] imx-drm: imx-tve: remove unused variable
Date: Sun, 25 May 2014 23:54:14 +0200
Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret
unused; remove it.
This fixes the following compilation warning:
drivers/staging/imx-drm/imx-tve.c: In function ‘imx_tve_connector_mode_valid’:
drivers/staging/imx-drm/imx-tve.c:252:6: warning: unused variable ‘ret’ [-Wunused-variable]
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Hi,
This can be seen with e.g. linux next-20140523 and arm allmodconfig.
Best regards,
V.
drivers/staging/imx-drm/imx-tve.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c
index 3e8b0a1..4caef2b1 100644
--- a/drivers/staging/imx-drm/imx-tve.c
+++ b/drivers/staging/imx-drm/imx-tve.c
@@ -249,7 +249,6 @@ static int imx_tve_connector_mode_valid(struct drm_connector *connector,
{
struct imx_tve *tve = con_to_tve(connector);
unsigned long rate;
- int ret;
/* pixel clock with 2x oversampling */
rate = clk_round_rate(tve->clk, 2000UL * mode->clock) / 2000;
--
2.0.0.rc2
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] imx-drm: imx-tve: remove unused variable
2014-05-25 23:12 ` Stephen Rothwell
@ 2014-05-27 12:56 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2014-05-27 12:56 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg Kroah-Hartman, Vincent Stehlé, devel, linux-kernel,
linux-next, Daniel Vetter, Andrzej Hajda, Dave Airlie
On Mon, May 26, 2014 at 09:12:52AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Sun, 25 May 2014 15:12:35 -0700 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote:
> > > Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret
> > > unused; remove it.
> > >
> > > This fixes the following compilation warning:
> > >
> > > drivers/staging/imx-drm/imx-tve.c: In function ‘imx_tve_connector_mode_valid’:
> > > drivers/staging/imx-drm/imx-tve.c:252:6: warning: unused variable ‘ret’ [-Wunused-variable]
> >
> > It doesn't apply to my tree :(
>
> Yeah, commit f9b0e251dfbf 'drm: make mode_valid callback optional' is
> in the drm tree, so this patch needs to go to Dave Airlie (cc'd).
> Though Daniel Vetter may want to send it on.
>
> For Dave's benefit, here is the patch again:
I've pulled it into my drm-stuff branch so it doesn't get lost. Should
land in 3.16 one way or the other.
Thanks, Daniel
>
> From: Vincent Stehlé <vincent.stehle@laposte.net>
> Subject: [PATCH linux-next] imx-drm: imx-tve: remove unused variable
> Date: Sun, 25 May 2014 23:54:14 +0200
>
> Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret
> unused; remove it.
>
> This fixes the following compilation warning:
>
> drivers/staging/imx-drm/imx-tve.c: In function ‘imx_tve_connector_mode_valid’:
> drivers/staging/imx-drm/imx-tve.c:252:6: warning: unused variable ‘ret’ [-Wunused-variable]
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>
> Hi,
>
> This can be seen with e.g. linux next-20140523 and arm allmodconfig.
>
> Best regards,
>
> V.
>
> drivers/staging/imx-drm/imx-tve.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c
> index 3e8b0a1..4caef2b1 100644
> --- a/drivers/staging/imx-drm/imx-tve.c
> +++ b/drivers/staging/imx-drm/imx-tve.c
> @@ -249,7 +249,6 @@ static int imx_tve_connector_mode_valid(struct drm_connector *connector,
> {
> struct imx_tve *tve = con_to_tve(connector);
> unsigned long rate;
> - int ret;
>
> /* pixel clock with 2x oversampling */
> rate = clk_round_rate(tve->clk, 2000UL * mode->clock) / 2000;
> --
> 2.0.0.rc2
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-27 12:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-25 21:54 [PATCH linux-next] imx-drm: imx-tve: remove unused variable Vincent Stehlé
2014-05-25 22:12 ` Greg Kroah-Hartman
2014-05-25 23:12 ` Stephen Rothwell
2014-05-27 12:56 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox