Re: linux-next: build failure after merge of the akpm-current tree

Paul Bolle
2016-06-15T21:12:44Z

Hi Josh,

On wo, 2016-06-15 at 09:03 -0500, Josh Poimboeuf wrote:
> I agree it looks like a false positive, though the code is a bit
> convoluted, so I'm not surprised that gcc might get confused.

Agree.

> How about initializing opt to 0?

I'm unconvinced. Especially since this only shows up in 64 bits builds.

> --- a/net/netfilter/ipvs/ip_vs_sync.c
> +++ b/net/netfilter/ipvs/ip_vs_sync.c

> static inline int ip_vs_proc_sync_conn(struct netns_ipvs *ipvs, __u8

> - struct ip_vs_sync_conn_options opt;
> + struct ip_vs_sync_conn_options opt = {0};

You forgot to append
/* I give up */

here. More common would be to use
/* silence GCC */
Thanks,

Paul Bolle