From: Guenter Roeck <linux@roeck-us.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: linux-next: Tree for Aug 23
Date: Tue, 2 Sep 2014 10:59:02 -0700 [thread overview]
Message-ID: <20140902175902.GA8829@roeck-us.net> (raw)
In-Reply-To: <20140902094016.GD31157@worktop.ger.corp.intel.com>
On Tue, Sep 02, 2014 at 11:40:16AM +0200, Peter Zijlstra wrote:
> On Mon, Sep 01, 2014 at 09:04:38PM +0200, Peter Zijlstra wrote:
> > On Mon, Sep 01, 2014 at 09:46:42AM -0700, Guenter Roeck wrote:
> > > Yes, the problem is still seen in next-140829. See qemu test results at
> > > http://server.roeck-us.net:8010/builders.
> > >
> > > I provided sparc64 images at http://server.roeck-us.net/qemu/sparc64/.
> > > The README file includes instructions on how to run the image in qemu
> > > and how to build a kernel.
> > >
> > > I can do the same for mips and mips64 if needed; let me know.
> >
> > Thanks, that's enough to get started.
>
> This makes sparc64 go again, silly oversight indeed.
>
> ---
> Subject: sparc64: Fix atomics
>
> The patch folding the atomic ops had a silly fail in the _return primitives.
>
> Fixes: 4f3316c2b5fe ("locking,arch,sparc: Fold atomic_ops")
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Confirmed working.
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> diff --git a/arch/sparc/lib/atomic_64.S b/arch/sparc/lib/atomic_64.S
> index 96d70b4..05dac43 100644
> --- a/arch/sparc/lib/atomic_64.S
> +++ b/arch/sparc/lib/atomic_64.S
> @@ -37,7 +37,7 @@ ENTRY(atomic_##op##_return) /* %o0 = increment, %o1 = atomic_ptr */ \
> cas [%o1], %g1, %g7; \
> cmp %g1, %g7; \
> bne,pn %icc, BACKOFF_LABEL(2f, 1b); \
> - add %g1, %o0, %g1; \
> + op %g1, %o0, %g1; \
> retl; \
> sra %g1, 0, %o0; \
> 2: BACKOFF_SPIN(%o2, %o3, 1b); \
> @@ -76,7 +76,7 @@ ENTRY(atomic64_##op##_return) /* %o0 = increment, %o1 = atomic_ptr */ \
> bne,pn %xcc, BACKOFF_LABEL(2f, 1b); \
> nop; \
> retl; \
> - add %g1, %o0, %o0; \
> + op %g1, %o0, %o0; \
> 2: BACKOFF_SPIN(%o2, %o3, 1b); \
> ENDPROC(atomic64_##op##_return);
>
>
>
next prev parent reply other threads:[~2014-09-02 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 22:04 linux-next: Tree for Aug 23 Stephen Rothwell
2014-08-25 4:57 ` Guenter Roeck
2014-09-01 15:58 ` Peter Zijlstra
2014-09-01 16:46 ` Guenter Roeck
2014-09-01 19:04 ` Peter Zijlstra
2014-09-02 9:40 ` Peter Zijlstra
2014-09-02 9:55 ` Peter Zijlstra
2014-09-02 19:04 ` Guenter Roeck
2014-09-02 20:21 ` Peter Zijlstra
2014-09-02 23:50 ` Guenter Roeck
2014-09-02 17:59 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-08-23 3:37 Stephen Rothwell
2023-08-23 6:14 Stephen Rothwell
2022-08-23 5:26 Stephen Rothwell
2021-08-23 10:26 Stephen Rothwell
2019-08-23 9:26 Stephen Rothwell
2019-08-24 2:37 ` John Hubbard
2018-08-23 3:32 Stephen Rothwell
2017-08-23 7:09 Stephen Rothwell
2016-08-23 4:55 Stephen Rothwell
2012-08-23 5:22 Stephen Rothwell
2011-08-23 6:04 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902175902.GA8829@roeck-us.net \
--to=linux@roeck-us.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).