linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Josh Triplett <josh@joshtriplett.org>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Oleg Nesterov <oleg@redhat.com>
Subject: linux-next: manual merge of the tiny tree with the tip tree
Date: Tue, 23 Sep 2014 14:32:32 +1000	[thread overview]
Message-ID: <20140923143232.5ffff46e@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 3156 bytes --]

Hi Josh,

Today's linux-next merge of the tiny tree got conflicts in
arch/x86/kernel/process_32.c and arch/x86/kernel/process_64.c between
commits dc56c0f9b870 ("x86, fpu: Shift "fpu_counter = 0" from
copy_thread() to arch_dup_task_struct()") and 6f46b3aef003 ("x86:
copy_thread: Don't nullify ->ptrace_bps twice") from the tip tree and
commits a1cf09f93e66 ("x86: process: Unify 32-bit and 64-bit
copy_thread I/O bitmap handling") and e4a191d1e05b ("x86: Support
compiling out userspace I/O (iopl and ioperm)") from the tiny tree.

I fixed it up (I think - see below) and can carry the fix as necessary
(no action is required).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc arch/x86/kernel/process_32.c
index 8f3ebfe710d0,e37f006fda6e..000000000000
--- a/arch/x86/kernel/process_32.c
+++ b/arch/x86/kernel/process_32.c
@@@ -153,7 -153,9 +154,7 @@@ int copy_thread(unsigned long clone_fla
  		childregs->orig_ax = -1;
  		childregs->cs = __KERNEL_CS | get_kernel_rpl();
  		childregs->flags = X86_EFLAGS_IF | X86_EFLAGS_FIXED;
- 		p->thread.io_bitmap_ptr = NULL;
 -		p->thread.fpu_counter = 0;
+ 		clear_thread_io_bitmap(p);
 -		memset(p->thread.ptrace_bps, 0, sizeof(p->thread.ptrace_bps));
  		return 0;
  	}
  	*childregs = *current_pt_regs();
@@@ -164,22 -166,12 +165,9 @@@
  	p->thread.ip = (unsigned long) ret_from_fork;
  	task_user_gs(p) = get_user_gs(current_pt_regs());
  
- 	p->thread.io_bitmap_ptr = NULL;
 -	p->thread.fpu_counter = 0;
+ 	clear_thread_io_bitmap(p);
  	tsk = current;
- 	err = -ENOMEM;
- 
- 	if (unlikely(test_tsk_thread_flag(tsk, TIF_IO_BITMAP))) {
- 		p->thread.io_bitmap_ptr = kmemdup(tsk->thread.io_bitmap_ptr,
- 						IO_BITMAP_BYTES, GFP_KERNEL);
- 		if (!p->thread.io_bitmap_ptr) {
- 			p->thread.io_bitmap_max = 0;
- 			return -ENOMEM;
- 		}
- 		set_tsk_thread_flag(p, TIF_IO_BITMAP);
- 	}
- 
- 	err = 0;
  
 -	memset(p->thread.ptrace_bps, 0, sizeof(p->thread.ptrace_bps));
 -
  	/*
  	 * Set a new TLS for the child thread?
  	 */
diff --cc arch/x86/kernel/process_64.c
index 3ed4a68d4013,80f348659edd..000000000000
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@@ -163,7 -164,8 +164,7 @@@ int copy_thread(unsigned long clone_fla
  	p->thread.sp = (unsigned long) childregs;
  	p->thread.usersp = me->thread.usersp;
  	set_tsk_thread_flag(p, TIF_FORK);
- 	p->thread.io_bitmap_ptr = NULL;
 -	p->thread.fpu_counter = 0;
+ 	clear_thread_io_bitmap(p);
  
  	savesegment(gs, p->thread.gsindex);
  	p->thread.gs = p->thread.gsindex ? 0 : me->thread.gs;
@@@ -191,17 -193,8 +192,6 @@@
  	if (sp)
  		childregs->sp = sp;
  
- 	err = -ENOMEM;
- 	if (unlikely(test_tsk_thread_flag(me, TIF_IO_BITMAP))) {
- 		p->thread.io_bitmap_ptr = kmemdup(me->thread.io_bitmap_ptr,
- 						  IO_BITMAP_BYTES, GFP_KERNEL);
- 		if (!p->thread.io_bitmap_ptr) {
- 			p->thread.io_bitmap_max = 0;
- 			return -ENOMEM;
- 		}
- 		set_tsk_thread_flag(p, TIF_IO_BITMAP);
- 	}
 -	memset(p->thread.ptrace_bps, 0, sizeof(p->thread.ptrace_bps));
--
  	/*
  	 * Set a new TLS for the child thread?
  	 */

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

             reply	other threads:[~2014-09-23  4:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  4:32 Stephen Rothwell [this message]
2014-09-23  5:43 ` linux-next: manual merge of the tiny tree with the tip tree Ingo Molnar
2014-09-23  6:21   ` Josh Triplett
2014-09-23  8:36     ` Ingo Molnar
2014-10-29 15:52       ` Josh Triplett
  -- strict thread matches above, loose matches on Subject: below --
2014-11-25  6:03 Stephen Rothwell
2014-11-25  6:16 ` Ingo Molnar
2014-11-25  6:30   ` John Stultz
2014-11-25  7:20     ` Josh Triplett
2014-11-25  6:48   ` Josh Triplett
2014-11-25 10:10     ` Ingo Molnar
2014-11-26  0:04       ` josh
2014-12-08 11:09         ` Ingo Molnar
2014-09-26  6:45 Stephen Rothwell
2014-09-23  4:23 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140923143232.5ffff46e@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=hpa@zytor.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).