From: Maninder Singh <maninder1.s@samsung.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>, Petr Mladek <pmladek@suse.com>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vaneet Narang <v.narang@samsung.com>,
PANKAJ MISHRA <pankaj.m@samsung.com>
Subject: RE: linux-next: build warning after merge of the printk tree
Date: Tue, 10 Jul 2018 12:46:14 +0530 [thread overview]
Message-ID: <2014348883.271177.1531206974788.JavaMail.jboss@ep1ml503> (raw)
In-Reply-To: <20180710164514.22c552db@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
Hi Petr,
> Hi all,
> After merging the printk tree, today's linux-next build (x86_64
> allnoconfig) produced this warning:
> kernel/printk/printk.c:2033:13: warning: 'suppress_message_printing' defined but not used [-Wunused-function]
> static bool suppress_message_printing(int level) { return false; }
^~~~~~~~~~~~~~~~~~~~~~~~~
seems there is no user for suppress_message_printing when CONFIG_PRINTK is disabled,
because earlier it was getting used in console_unlock and now we shifted this into vprintk_emit
which will be disabled on disabling CONFIG_PRINTk.
should we remove this defination when CONFIG_PRINTK is disabled ?
> Introduced by commit
> 375899cddcbb ("printk: make sure to print log on console.")
[-- Attachment #2: No File Name 0 --]
[-- Type: application/octet-stream, Size: 499 bytes --]
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAltEVfoACgkQAVBC80lX
0GxQTwf9EZwdtrXMLQwD1/qJOadRHs1fyvT5nyUdMbCPctaMkdIm4Nsyx1lai8r/
oFMjjlMqmwO+YqneRwojhv+nAZ77+CtBURnV7k2riazf3mHcrUjHCzfQ2el5Fgsj
6p3Yaowl45+lTVYa9uEZxs59QWWFrZnfPKdDk8jDFeFppG1N3UHr9rQJm9pis6TA
9rZFucyeWAZAe7wMkbpeKPl8whpVUPXxwDgtgIjiotVg5tKluC7RNcQwLzMbBH0o
u2haX3SDfeqOdxi05Weh4QIXKo7kFAyX3os+wyyUPoIv40uWuhLAf1I6WhdPBdbi
gLCiuK5xrnNYmgxURg7moHUQ+0PzDw==
=bSrM
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2018-07-10 7:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180710064527epcas1p16fd9ad765711d69264b3251890bbcc2e@epcms5p5>
2018-07-10 6:45 ` linux-next: build warning after merge of the printk tree Stephen Rothwell
2018-07-10 7:16 ` Maninder Singh [this message]
2018-07-10 9:19 ` Petr Mladek
2018-07-10 11:53 ` [PATCH] printk: Fix warning about unused suppress_message_printing kbuild test robot
2018-07-10 13:15 ` linux-next: build warning after merge of the printk tree Sergey Senozhatsky
2021-07-20 6:24 Stephen Rothwell
2021-07-20 12:18 ` Chris Down
2021-07-20 12:22 ` Chris Down
2021-07-25 21:16 ` Jonathan Corbet
2021-07-26 12:28 ` Petr Mladek
2021-07-26 13:07 ` Chris Down
-- strict thread matches above, loose matches on Subject: below --
2022-11-22 7:10 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2014348883.271177.1531206974788.JavaMail.jboss@ep1ml503 \
--to=maninder1.s@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=pmladek@suse.com \
--cc=sfr@canb.auug.org.au \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox