From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: livepatching tree for linux-next Date: Wed, 7 Jan 2015 15:57:01 -0800 Message-ID: <20150107155701.4839545f63701412003edd88@linux-foundation.org> References: <20141223094607.GA16445@infradead.org> <20141223151056.GA4789@treble.redhat.com> <20141226155613.36dd95b9@canb.auug.org.au> <20150107144317.61ab2080877a4d8227990551@linux-foundation.org> <20150107153006.60ed354e3458f402e6819b9e@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34337 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755810AbbAGX5C (ORCPT ); Wed, 7 Jan 2015 18:57:02 -0500 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Jiri Kosina Cc: Stephen Rothwell , Josh Poimboeuf , Christoph Hellwig , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, linux-next@vger.kernel.org, Steven Rostedt , Masami Hiramatsu On Thu, 8 Jan 2015 00:49:49 +0100 (CET) Jiri Kosina wrote: > --- a/kernel/livepatch/core.c > +++ b/kernel/livepatch/core.c > @@ -911,6 +911,12 @@ static int klp_init(void) > { > int ret; > > + ret = klp_check_compiler_support(); > + if (ret) { > + pr_info("Your compiler is too old; turning off.\n"); > + return -EINVAL; > + } > + Looks reasonable. It's a shame we've never figured out a way to do this at Kconfig-time. That second #error doing in livepatch.h is a bit odd. It errors out if anyone includes livepatch.h when CONFIG_LIVE_PATCHING=n. Methinks it would be saner to change it to #error include linux/livepatch.h, not asm/livepatch.h