From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: randconfig build error with next-20150112, in drivers/hwmon/gpio-fan.c Date: Mon, 12 Jan 2015 09:25:37 -0800 Message-ID: <20150112172537.GA19868@roeck-us.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:55871 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbbALRZn (ORCPT ); Mon, 12 Jan 2015 12:25:43 -0500 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1YAikJ-0037Pc-DJ for linux-next@vger.kernel.org; Mon, 12 Jan 2015 17:25:43 +0000 Content-Disposition: inline In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Jim Davis Cc: linux-next , linux-kernel , jdelvare@suse.de, Grant Likely , Rob Herring , lm-sensors@lm-sensors.org, devicetree , Nishanth Menon , Eduardo Valentin On Mon, Jan 12, 2015 at 09:53:05AM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/built-in.o: In function `gpio_fan_remove': > gpio-fan.c:(.text+0x6efea): undefined reference to > `thermal_cooling_device_unregister' > drivers/built-in.o: In function `gpio_fan_probe': > gpio-fan.c:(.text+0x6f376): undefined reference to > `thermal_cooling_device_register' > make: *** [vmlinux] Error 1 Hi Jim, thanks for the note. Hmm .. turns out those functions don't define dummies if CONFIG_THERMAL is not configured. How annoying. Nishant, please fix your gpio-fan patch. I am going to drop it for now. Please keep in mind that there is a secondary dependency: The thermal code can be built as module. In that case, the gpio-fan driver must either also be built as module, or its thermal registration must be disabled. Guenter