linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Felipe Balbi <balbi@ti.com>, Nishanth Menon <nm@ti.com>,
	linux-mm@kvack.org, linux-next <linux-next@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [next-20150119]regression (mm)?
Date: Tue, 20 Jan 2015 16:05:46 +0200 (EET)	[thread overview]
Message-ID: <20150120140546.DDCB8D4@black.fi.intel.com> (raw)
In-Reply-To: <20150120114555.GA11502@n2100.arm.linux.org.uk>

Russell King - ARM Linux wrote:
> On Tue, Jan 20, 2015 at 02:16:43AM +0200, Kirill A. Shutemov wrote:
> > Better option would be converting 2-lvl ARM configuration to
> > <asm-generic/pgtable-nopmd.h>, but I'm not sure if it's possible.
> 
> Well, IMHO the folded approach in asm-generic was done the wrong way
> which barred ARM from ever using it.

Okay, I see.

Regarding the topic bug. Completely untested patch is below. Could anybody
check if it helps?

>From 34b9182d08ef2b541829e305fcc91ef1d26b27ea Mon Sep 17 00:00:00 2001
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Date: Tue, 20 Jan 2015 15:47:22 +0200
Subject: [PATCH] arm: define __PAGETABLE_PMD_FOLDED for !LPAE

ARM uses custom implementation of PMD folding in 2-level page table case.
Generic code expects to see __PAGETABLE_PMD_FOLDED to be defined if PMD is
folded, but ARM doesn't do this. Let's fix it.

Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc().
It also fixes problems with recently-introduced pmd accounting on ARM
without LPAE.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reported-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/include/asm/pgtable-2level.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/include/asm/pgtable-2level.h b/arch/arm/include/asm/pgtable-2level.h
index bcc5e300413f..bfd662e49a25 100644
--- a/arch/arm/include/asm/pgtable-2level.h
+++ b/arch/arm/include/asm/pgtable-2level.h
@@ -10,6 +10,8 @@
 #ifndef _ASM_PGTABLE_2LEVEL_H
 #define _ASM_PGTABLE_2LEVEL_H
 
+#define __PAGETABLE_PMD_FOLDED
+
 /*
  * Hardware-wise, we have a two level page table structure, where the first
  * level has 4096 entries, and the second level has 256 entries.  Each entry
-- 
2.1.4

  reply	other threads:[~2015-01-20 14:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 16:42 [next-20150119]regression (mm)? Nishanth Menon
     [not found] ` <CANMBJr6DudDBSs+rM-e2QnC5ztxAYLuSvZ0khvx7OZdQpcu_3A@mail.gmail.com>
2015-01-19 17:04   ` Nishanth Menon
2015-01-19 17:19     ` Tyler Baker
2015-01-19 17:43 ` Felipe Balbi
2015-01-20  0:16   ` Kirill A. Shutemov
2015-01-20 11:45     ` Russell King - ARM Linux
2015-01-20 14:05       ` Kirill A. Shutemov [this message]
2015-01-20 14:50         ` Fabio Estevam
2015-01-20 15:10           ` Felipe Balbi
2015-01-20 23:26         ` Nishanth Menon
2015-01-21  9:23         ` Peter Ujfalusi
2015-01-21 10:29         ` Krzysztof Kozlowski
2015-01-23 17:27         ` Nishanth Menon
2015-01-23 17:39           ` Tyler Baker
2015-01-23 18:37             ` Nishanth Menon
2015-01-23 20:22               ` Kirill A. Shutemov
2015-01-23 22:05                 ` Nishanth Menon
2015-01-23 22:42                 ` Tyler Baker
2015-01-24  1:13                   ` Kirill A. Shutemov
2015-01-24  4:37                     ` Nishanth Menon
2015-01-26 12:00                       ` Kirill A. Shutemov
2015-01-26 22:38                         ` Tyler Baker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120140546.DDCB8D4@black.fi.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).