linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Alban Browaeys <alban.browaeys@gmail.com>
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	Inki Dae <inki.dae@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	linux-samsung-soc@vger.kernel.org, linux-next@vger.kernel.org,
	Alban Browaeys <prahal@yahoo.com>
Subject: Re: [PATCH] exynos/drm: fix no hdmi output
Date: Fri, 30 Jan 2015 12:55:08 -0200	[thread overview]
Message-ID: <20150130145508.GF30820@joana> (raw)
In-Reply-To: <1422566320-6126-1-git-send-email-prahal@yahoo.com>

Hi Alban,

2015-01-29 Alban Browaeys <alban.browaeys@gmail.com>:

> The hdmi outputs black screen only even though under the hood Xorg and
> framebuffer console  are fine : devices found and initialized, but
> not a pixel out.
> 
> Commit 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
> changed the call order of mixer_initialize with regards to
>  exynos_drm_crtc_create.
> 
> This changes breaks hdmi out on Odroid U2 (linux-next with added
>  Marek Szyprowski v4 hdmi patchset from linux-samsung-soc ML).
> 
> Restore the previous call ordering get hdmi to ouput proper pixels:
> ie call mixer_initialize first then exynos_drm_crtc_create.
> 
> Fixes: 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
>  drivers/gpu/drm/exynos/exynos_mixer.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

	Gustavo

  parent reply	other threads:[~2015-01-30 14:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 21:18 [PATCH] exynos/drm: fix no hdmi output Alban Browaeys
2015-01-30  0:24 ` Joonyoung Shim
2015-01-30  7:29   ` Joonyoung Shim
2015-01-30 14:55 ` Gustavo Padovan [this message]
2015-02-04  8:35 ` Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150130145508.GF30820@joana \
    --to=gustavo@padovan.org \
    --cc=alban.browaeys@gmail.com \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=prahal@yahoo.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).