Re: [PATCH 1/2] tracing: Add condition check to RCU lockdep checks

Steven Rostedt
2015-02-06T20:11:14Z

> diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> index e08e21e5f601..68a346b8328a 100644
> --- a/include/linux/tracepoint.h
> +++ b/include/linux/tracepoint.h
> @@ -173,7 +173,7 @@ extern void syscall_unregfunc(void);
> TP_PROTO(data_proto), \
> TP_ARGS(data_args), \
> TP_CONDITION(cond),,); \
> - if (IS_ENABLED(CONFIG_LOCKDEP)) { \
> + if (IS_ENABLED(CONFIG_LOCKDEP) && cond) { \

Bah,

cond needs to be in parenthesis. Will post a v2 of this patch.

-- Steve

> rcu_read_lock_sched_notrace(); \
> rcu_dereference_sched(__tracepoint_##name.funcs);\
> rcu_read_unlock_sched_notrace(); \