Re: [PATCH 0/2] tracing/tlb/x85: Fix splat of calling RCU trace code on offline CPU

Sedat Dilek
2015-02-06T23:02:48Z

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

On Fri, Feb 6, 2015 at 11:51 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> On Fri, Feb 6, 2015 at 11:48 PM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
>> On Fri, Feb 06, 2015 at 05:35:48PM -0500, Steven Rostedt wrote:
>>> On Fri, 6 Feb 2015 23:13:02 +0100
>>> Sedat Dilek <sedat.dilek@gmail.com> wrote:
>>>
>>>
>>> > OK, so both patches go through Steve's tree.
>>>
>>> The second patch will require acks from those that maintain the files I
>>> touch.
>>
>> Yep, that is required either way. I will give it an Acked-by in the hope
>> that this helps. You have another version on the way, or have I lost
>> count? ;-)
>>
>
> Working on x85 and probably using ed as $EDITOR, it will take some time.
>

Here is proposal for v2 as a diff to the original posted to LKML.

- Sedat -

[-- Attachment #2: 2-2.diff --]
[-- Type: text/plain, Size: 1222 bytes --]

--- 2-2.patch 2015-02-07 00:00:15.151621154 +0100
+++ 2-2-v2.patch 2015-02-06 23:59:22.187620716 +0100
@@ -2,7 +2,7 @@ From patchwork Fri Feb 6 20:06:55 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
-Subject: x86/tbl/trace: Do not trace on CPU that is offline
+Subject: x86/tlb/trace: Do not trace on CPU that is offline
From: Steven Rostedt <rostedt@goodmis.org>
X-Patchwork-Id: 5794701
Message-Id: <20150206200800.689573476@goodmis.org>
@@ -70,11 +70,21 @@ code when the CPU is offline.

Link: http://lkml.kernel.org/r/CA+icZUUGiGDoL5NU8RuxKzFjoLjEKRtUWx=JB8B9a0EQv-eGzQ@mail.gmail.com

+NOTE: This patch requires "tracing: Add condition check to RCU lockdep checks".
+
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
+Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
+Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

---
+
+[ dileks: v2:
+ - s/tbl/tlb in subject-line
+ - Add a reference to a preconditional patch
+ - Add Paul's Acked-by ]
+
include/trace/events/tlb.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)