linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Jim Davis <jim.epost@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next <linux-next@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	pali.rohar@gmail.com, platform-driver-x86@vger.kernel.org
Subject: Re: randconfig build error with next-20150521, in drivers/platform/x86/dell-rbtn.c
Date: Thu, 21 May 2015 21:56:15 +0200	[thread overview]
Message-ID: <20150521195615.GF22037@vmdeb7> (raw)
In-Reply-To: <CA+r1Zhij2wUuLK6cdhr44NFW+okW4YuyFoo2_58mR6yncsXo3w@mail.gmail.com>

On Thu, May 21, 2015 at 10:36:15AM -0700, Jim Davis wrote:
> Building with the attached random configuration file,
> 
> drivers/built-in.o: In function `rbtn_remove':
> dell-rbtn.c:(.text+0x31d7f4): undefined reference to `input_unregister_device'
> drivers/built-in.o: In function `rbtn_notify':
> dell-rbtn.c:(.text+0x31d8e5): undefined reference to `input_event'
> dell-rbtn.c:(.text+0x31d8f8): undefined reference to `input_event'
> dell-rbtn.c:(.text+0x31d911): undefined reference to `input_event'
> dell-rbtn.c:(.text+0x31d924): undefined reference to `input_event'
> drivers/built-in.o: In function `rbtn_add':
> dell-rbtn.c:(.text+0x31da11): undefined reference to `input_allocate_device'
> dell-rbtn.c:(.text+0x31da4a): undefined reference to `input_register_device'
> dell-rbtn.c:(.text+0x31da5e): undefined reference to `input_free_device'
> Makefile:938: recipe for target 'vmlinux' failed


Thanks Jim,

Pali, the DELL_RBTN needs to ensure if it it's built-in, that INPUT is too.
...
> CONFIG_INPUT=m
> CONFIG_INPUT_FF_MEMLESS=m
> CONFIG_INPUT_POLLDEV=m
> CONFIG_INPUT_SPARSEKMAP=m
> CONFIG_INPUT_MATRIXKMAP=m
...
> CONFIG_DELL_RBTN=y

Please submit a fix as a new patch.

-- 
Darren Hart
Intel Open Source Technology Center

  reply	other threads:[~2015-05-21 19:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 17:36 randconfig build error with next-20150521, in drivers/platform/x86/dell-rbtn.c Jim Davis
2015-05-21 19:56 ` Darren Hart [this message]
2015-05-21 20:07   ` Pali Rohár
2015-05-25  4:20     ` Darren Hart
2015-06-01 16:40     ` Randy Dunlap
2015-06-01 17:26       ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150521195615.GF22037@vmdeb7 \
    --to=dvhart@infradead.org \
    --cc=jim.epost@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).