linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Alasdair G Kergon <agk@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the device-mapper tree
Date: Fri, 22 May 2015 09:26:51 -0400	[thread overview]
Message-ID: <20150522132651.GA7590@redhat.com> (raw)
In-Reply-To: <20150522124938.GA7471@redhat.com>

On Fri, May 22 2015 at  8:49am -0400,
Mike Snitzer <snitzer@redhat.com> wrote:

> On Thu, May 21 2015 at 11:27pm -0400,
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi all,
> > 
> > After merging the device-mapper tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > block/bio.c:310:20: error: redefinition of 'bio_inc_remaining'
> >  static inline void bio_inc_remaining(struct bio *bio)
> >                     ^
> > In file included from block/bio.c:20:0:
> > include/linux/bio.h:664:20: note: previous definition of 'bio_inc_remaining' was here
> >  static inline void bio_inc_remaining(struct bio *bio)
> >                     ^
> > 
> > Caused by commit d61b82161c5a ("block: remove management of
> > bi_remaining when restoring original bi_end_io").
> > 
> > OK, this is a bad automatic merge caused by the fact that the block
> > tree and the device-mapper tree both contain the same set fo patches as
> > different commits.
> > 
> > Commit c4cf5261f8bf from the block tree is the same as commit
> > 8395711c4f90 from the device-mapper tree and both add
> > bio_inc_remaining() to include/linux/bio.h.  The above commit in the
> > device-mapper tree removes it from there, but the merge decided to keep
> > it.
> > 
> > That shared patch above is part of a series of 14 patches that are
> > identical patches but different commits and are causing quite a few
> > conflicts.  It looks like those patches were rebased onto v4.10rc3 as
> > the base for the device-mapper tree.  A better idea would have been to
> > start with v4.1rc3 (if that is necessary) and merge commit 5b3f341f098d
> > ("blk-mq: make plug work for mutiple disks and queues") from the block
> > tree - assuming that Jens will guarantee not to rebase that part of his
> > tree.
> > 
> > Please clean this mess up.
> 
> Will do.

I've fixed linux-dm's for-next to be properly based on linux-block's
for-4.2/core -- I also resent Jens three block patches for 4.2 that
motivated me to rebase ontop of block to begin with.

  reply	other threads:[~2015-05-22 13:26 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22  3:27 linux-next: build failure after merge of the device-mapper tree Stephen Rothwell
2015-05-22 12:49 ` Mike Snitzer
2015-05-22 13:26   ` Mike Snitzer [this message]
2015-05-22 14:58     ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2025-08-15  3:05 Stephen Rothwell
2025-08-15  8:05 ` Bagas Sanjaya
2025-08-15 15:21 ` Mikulas Patocka
2025-04-10  2:20 Stephen Rothwell
2024-02-07  3:40 Stephen Rothwell
2024-02-07  3:54 ` Matthew Sakai
2024-02-07 15:47 ` Mike Snitzer
2023-09-15  0:06 Stephen Rothwell
2023-06-23  4:30 Stephen Rothwell
2023-06-23 16:47 ` Demi Marie Obenour
2021-02-11  3:36 Stephen Rothwell
2021-02-11 14:37 ` Mike Snitzer
2020-04-22  2:54 Stephen Rothwell
2018-12-06  6:21 Stephen Rothwell
2018-12-06 13:41 ` Mike Snitzer
2018-12-06 20:23   ` Stephen Rothwell
2018-05-31  4:23 Stephen Rothwell
2018-05-31  4:35 ` Jens Axboe
2018-05-31  4:38   ` Stephen Rothwell
2018-05-31 12:10   ` Mike Snitzer
2018-05-31 14:20     ` Jens Axboe
2018-05-31 14:22       ` Jens Axboe
2018-05-31 15:02         ` Jens Axboe
2018-05-31 21:42           ` Stephen Rothwell
2018-03-27  2:39 Stephen Rothwell
2018-03-27 15:39 ` Bart Van Assche
2017-06-19  2:27 Stephen Rothwell
2017-06-09  3:12 Stephen Rothwell
2017-06-09  4:28 ` Damien Le Moal
2017-06-09 11:59   ` Mike Snitzer
2016-03-04  2:59 Stephen Rothwell
2016-03-04  3:14 ` Mike Snitzer
2015-11-01 10:43 Stephen Rothwell
2015-11-01 13:44 ` Mike Snitzer
2015-07-05 23:27 Stephen Rothwell
2014-01-15  3:52 Stephen Rothwell
2014-01-15  4:30 ` Mike Snitzer
2013-11-05  2:51 Stephen Rothwell
2013-11-05  3:20 ` Mike Snitzer
2013-11-05  3:32   ` Stephen Rothwell
2013-11-05 12:54     ` Mike Snitzer
2013-11-05 16:22       ` Jens Axboe
2013-11-05 22:42         ` Stephen Rothwell
2013-11-05 22:44           ` Jens Axboe
2010-08-02  1:31 Stephen Rothwell
2010-08-02  6:44 ` Milan Broz
2010-08-02 11:34 ` Alasdair G Kergon
2010-06-30  2:57 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150522132651.GA7590@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).