From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: randconfig build error with next-20150521, in drivers/platform/x86/dell-rbtn.c Date: Sun, 24 May 2015 21:20:18 -0700 Message-ID: <20150525042018.GA26644@fury.dvhart.com> References: <20150521195615.GF22037@vmdeb7> <201505212207.11872@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <201505212207.11872@pali> Sender: linux-kernel-owner@vger.kernel.org To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Jim Davis , Stephen Rothwell , linux-next , linux-kernel , platform-driver-x86@vger.kernel.org List-Id: linux-next.vger.kernel.org On Thu, May 21, 2015 at 10:07:11PM +0200, Pali Roh=E1r wrote: > On Thursday 21 May 2015 21:56:15 Darren Hart wrote: > > On Thu, May 21, 2015 at 10:36:15AM -0700, Jim Davis wrote: > > > Building with the attached random configuration file, > > >=20 > > > drivers/built-in.o: In function `rbtn_remove': > > > dell-rbtn.c:(.text+0x31d7f4): undefined reference to > > > `input_unregister_device' drivers/built-in.o: In function > > > `rbtn_notify': > > > dell-rbtn.c:(.text+0x31d8e5): undefined reference to `input_event= ' > > > dell-rbtn.c:(.text+0x31d8f8): undefined reference to `input_event= ' > > > dell-rbtn.c:(.text+0x31d911): undefined reference to `input_event= ' > > > dell-rbtn.c:(.text+0x31d924): undefined reference to `input_event= ' > > > drivers/built-in.o: In function `rbtn_add': > > > dell-rbtn.c:(.text+0x31da11): undefined reference to > > > `input_allocate_device' dell-rbtn.c:(.text+0x31da4a): undefined > > > reference to `input_register_device' dell-rbtn.c:(.text+0x31da5e)= : > > > undefined reference to `input_free_device' Makefile:938: recipe > > > for target 'vmlinux' failed > >=20 > > Thanks Jim, > >=20 > > Pali, the DELL_RBTN needs to ensure if it it's built-in, that INPUT > > is too. ... > >=20 > > > CONFIG_INPUT=3Dm > > > CONFIG_INPUT_FF_MEMLESS=3Dm > > > CONFIG_INPUT_POLLDEV=3Dm > > > CONFIG_INPUT_SPARSEKMAP=3Dm > > > CONFIG_INPUT_MATRIXKMAP=3Dm > >=20 > > ... > >=20 > > > CONFIG_DELL_RBTN=3Dy > >=20 > > Please submit a fix as a new patch. >=20 > I believe that this patch is needed: >=20 > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kcon= fig > index 8c03223..d025fd8 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -141,6 +141,7 @@ config DELL_SMO8800 > config DELL_RBTN > tristate "Dell Airplane Mode Switch driver" > depends on ACPI > + depends on INPUT > depends on RFKILL > ---help--- > Say Y here if you want to support Dell Airplane Mode Switch ACPI >=20 > I did not tested it yet, but all other drivers depends on INPUT. This looks reasonable to me. Please test it with the various configs an= d send the patch if it passes the tests. --=20 Darren Hart Intel Open Source Technology Center