Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'

Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'

[Guenter Roeck]

Hi,

your patch 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'
converts the driver into a separate module. Unfortunately, it uses
non-exported functions from the ehci core code. This results in compile
errors for several powerpc configurations.

drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_suspend':
drivers/usb/host/ehci-fsl.c:531:2: error: implicit declaration of function 'ehci_adjust_port_wakeup_flags'
drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_resume':
drivers/usb/host/ehci-fsl.c:561:2: error: implicit declaration of function 'ehci_reset'

Guenter

RE: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'

[Ramneek Mehresh]

> -----Original Message-----
> From: Guenter Roeck [mailto:linux@roeck-us.net]
> Sent: Thursday, May 28, 2015 1:29 AM
> To: Mehresh Ramneek-B31383
> Cc: Alan Stern; Greg Kroah-Hartman; linux-kernel@vger.kernel.org; linux-
> next@vger.kernel.org
> Subject: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an
> independent driver module'
> 
> Hi,
> 
> your patch 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'
> converts the driver into a separate module. Unfortunately, it uses non-
> exported functions from the ehci core code. This results in compile errors for
> several powerpc configurations.
> 
> drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_suspend':
> drivers/usb/host/ehci-fsl.c:531:2: error: implicit declaration of function
> 'ehci_adjust_port_wakeup_flags'
> drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_resume':
> drivers/usb/host/ehci-fsl.c:561:2: error: implicit declaration of function
> 'ehci_reset'
>
Understood...apologies for the inconvenience caused. This problem comes when both 
ehci_hcd and ehci_fsl are built as modules. Till now, only ehci-hcd was build as 
module, and other drivers were built into it. I tested ehci_fsl as a module with ehci_hcd as build-in.

Now, there are two solutions for this.
1. export each function in ehci_hcd.c
2. I make ehci-fsl.c as built-in

Please suggest.
 
> Guenter

RE: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'

[Ramneek Mehresh]

> -----Original Message-----
> From: Mehresh Ramneek-B31383
> Sent: Thursday, May 28, 2015 9:25 AM
> To: 'Guenter Roeck'
> Cc: Alan Stern; Greg Kroah-Hartman; linux-kernel@vger.kernel.org; linux-
> next@vger.kernel.org
> Subject: RE: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an
> independent driver module'
> 
> 
> 
> > -----Original Message-----
> > From: Guenter Roeck [mailto:linux@roeck-us.net]
> > Sent: Thursday, May 28, 2015 1:29 AM
> > To: Mehresh Ramneek-B31383
> > Cc: Alan Stern; Greg Kroah-Hartman; linux-kernel@vger.kernel.org;
> > linux- next@vger.kernel.org
> > Subject: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci
> > drv an independent driver module'
> >
> > Hi,
> >
> > your patch 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'
> > converts the driver into a separate module. Unfortunately, it uses
> > non- exported functions from the ehci core code. This results in
> > compile errors for several powerpc configurations.
> >
> > drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_suspend':
> > drivers/usb/host/ehci-fsl.c:531:2: error: implicit declaration of
> > function 'ehci_adjust_port_wakeup_flags'
> > drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_resume':
> > drivers/usb/host/ehci-fsl.c:561:2: error: implicit declaration of
> > function 'ehci_reset'
> >
> Understood...apologies for the inconvenience caused. This problem comes
> when both ehci_hcd and ehci_fsl are built as modules. Till now, only ehci-hcd
> was build as module, and other drivers were built into it. I tested ehci_fsl as a
> module with ehci_hcd as build-in.
> 
> Now, there are two solutions for this.
> 1. export each function in ehci_hcd.c
> 2. I make ehci-fsl.c as built-in
> 
> Please suggest.
> 
I just reproduced the issue...it comes when USB driver is compiled with PM enabled !!
That's why we missed this this. I'll send the fix immediately.
> > Guenter