From: Felipe Balbi <balbi@ti.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Felipe Balbi" <balbi@ti.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the usb-gadget tree
Date: Fri, 29 May 2015 10:19:21 -0500 [thread overview]
Message-ID: <20150529151921.GD2026@saruman.tx.rr.com> (raw)
In-Reply-To: <20150529183213.7db39b9b@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 3438 bytes --]
On Fri, May 29, 2015 at 06:32:13PM +1000, Stephen Rothwell wrote:
> Hi Felipe,
>
> After merging the usb-gadget tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from include/linux/module.h:17:0,
> from drivers/usb/gadget/legacy/nokia.c:19:
> drivers/usb/gadget/legacy/nokia.c: In function '__check_num_buffers':
> drivers/usb/gadget/function/f_mass_storage.h:51:34: error: 'fsg_num_buffers' undeclared (first use in this function)
> module_param_named(num_buffers, fsg_num_buffers, uint, S_IRUGO);\
> ^
> include/linux/moduleparam.h:387:68: note: in definition of macro '__param_check'
> static inline type __always_unused *__check_##name(void) { return(p); }
> ^
> include/linux/moduleparam.h:145:2: note: in expansion of macro 'param_check_uint'
> param_check_##type(name, &(value)); \
> ^
> drivers/usb/gadget/function/f_mass_storage.h:51:2: note: in expansion of macro 'module_param_named'
> module_param_named(num_buffers, fsg_num_buffers, uint, S_IRUGO);\
> ^
> drivers/usb/gadget/legacy/nokia.c:45:1: note: in expansion of macro 'FSG_MODULE_PARAMETERS'
> FSG_MODULE_PARAMETERS(/* no prefix */, fsg_mod_data);
> ^
> drivers/usb/gadget/function/f_mass_storage.h:51:34: note: each undeclared identifier is reported only once for each function it appears in
> module_param_named(num_buffers, fsg_num_buffers, uint, S_IRUGO);\
> ^
> include/linux/moduleparam.h:387:68: note: in definition of macro '__param_check'
> static inline type __always_unused *__check_##name(void) { return(p); }
> ^
> include/linux/moduleparam.h:145:2: note: in expansion of macro 'param_check_uint'
> param_check_##type(name, &(value)); \
> ^
> drivers/usb/gadget/function/f_mass_storage.h:51:2: note: in expansion of macro 'module_param_named'
> module_param_named(num_buffers, fsg_num_buffers, uint, S_IRUGO);\
> ^
> drivers/usb/gadget/legacy/nokia.c:45:1: note: in expansion of macro 'FSG_MODULE_PARAMETERS'
> FSG_MODULE_PARAMETERS(/* no prefix */, fsg_mod_data);
> ^
> drivers/usb/gadget/legacy/nokia.c: At top level:
> drivers/usb/gadget/function/f_mass_storage.h:51:34: error: 'fsg_num_buffers' undeclared here (not in a function)
> module_param_named(num_buffers, fsg_num_buffers, uint, S_IRUGO);\
> ^
> include/linux/moduleparam.h:224:22: note: in definition of macro '__module_param_call'
> level, flags, { arg } }
> ^
> include/linux/moduleparam.h:146:2: note: in expansion of macro 'module_param_cb'
> module_param_cb(name, ¶m_ops_##type, &value, perm); \
> ^
> drivers/usb/gadget/function/f_mass_storage.h:51:2: note: in expansion of macro 'module_param_named'
> module_param_named(num_buffers, fsg_num_buffers, uint, S_IRUGO);\
> ^
> drivers/usb/gadget/legacy/nokia.c:45:1: note: in expansion of macro 'FSG_MODULE_PARAMETERS'
> FSG_MODULE_PARAMETERS(/* no prefix */, fsg_mod_data);
> ^
>
> Caused by commit e4f8ef7b0770 ("usb: gadget: nokia: Add mass storage
> driver to g_nokia").
>
> I have used the usb-gadget tree from next-20150528 for today.
I'll drop that patch, thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-29 15:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 8:32 linux-next: build failure after merge of the usb-gadget tree Stephen Rothwell
2015-05-29 15:19 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-16 3:37 Stephen Rothwell
2020-03-16 17:42 ` John Stultz
2020-03-16 18:11 ` John Stultz
2020-03-16 19:46 ` Greg KH
2013-12-16 4:40 Stephen Rothwell
2013-12-16 19:41 ` Felipe Balbi
2013-12-16 23:10 ` Stephen Rothwell
2013-12-16 23:38 ` Felipe Balbi
2013-12-17 4:27 ` Stephen Rothwell
2013-12-09 3:58 Stephen Rothwell
2013-12-09 4:11 ` Felipe Balbi
2013-12-09 19:40 ` Felipe Balbi
2013-12-09 20:43 ` Stephen Rothwell
2013-12-09 21:01 ` Felipe Balbi
2013-12-09 21:42 ` Felipe Balbi
2013-12-17 4:36 ` Stephen Rothwell
2013-12-17 5:08 ` Felipe Balbi
2013-12-17 5:13 ` Felipe Balbi
2013-07-30 4:34 Stephen Rothwell
2013-07-30 5:49 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529151921.GD2026@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).