From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: randconfig build error with next-20150521, in drivers/platform/x86/dell-rbtn.c Date: Mon, 1 Jun 2015 19:26:50 +0200 Message-ID: <20150601172650.GA80980@vmdeb7> References: <20150521195615.GF22037@vmdeb7> <201505212207.11872@pali> <556C8B10.8040000@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:33278 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbbFAR0h (ORCPT ); Mon, 1 Jun 2015 13:26:37 -0400 Content-Disposition: inline In-Reply-To: <556C8B10.8040000@infradead.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Jim Davis , Stephen Rothwell , linux-next , linux-kernel , platform-driver-x86@vger.kernel.org On Mon, Jun 01, 2015 at 09:40:48AM -0700, Randy Dunlap wrote: > On 05/21/15 13:07, Pali Roh=E1r wrote: > > On Thursday 21 May 2015 21:56:15 Darren Hart wrote: > >> On Thu, May 21, 2015 at 10:36:15AM -0700, Jim Davis wrote: > >>> Building with the attached random configuration file, > >>> > >>> drivers/built-in.o: In function `rbtn_remove': > >>> dell-rbtn.c:(.text+0x31d7f4): undefined reference to > >>> `input_unregister_device' drivers/built-in.o: In function > >>> `rbtn_notify': > >>> dell-rbtn.c:(.text+0x31d8e5): undefined reference to `input_event= ' > >>> dell-rbtn.c:(.text+0x31d8f8): undefined reference to `input_event= ' > >>> dell-rbtn.c:(.text+0x31d911): undefined reference to `input_event= ' > >>> dell-rbtn.c:(.text+0x31d924): undefined reference to `input_event= ' > >>> drivers/built-in.o: In function `rbtn_add': > >>> dell-rbtn.c:(.text+0x31da11): undefined reference to > >>> `input_allocate_device' dell-rbtn.c:(.text+0x31da4a): undefined > >>> reference to `input_register_device' dell-rbtn.c:(.text+0x31da5e)= : > >>> undefined reference to `input_free_device' Makefile:938: recipe > >>> for target 'vmlinux' failed > >> > >> Thanks Jim, > >> > >> Pali, the DELL_RBTN needs to ensure if it it's built-in, that INPU= T > >> is too. ... > >> > >>> CONFIG_INPUT=3Dm > >>> CONFIG_INPUT_FF_MEMLESS=3Dm > >>> CONFIG_INPUT_POLLDEV=3Dm > >>> CONFIG_INPUT_SPARSEKMAP=3Dm > >>> CONFIG_INPUT_MATRIXKMAP=3Dm > >> > >> ... > >> > >>> CONFIG_DELL_RBTN=3Dy > >> > >> Please submit a fix as a new patch. > >=20 > > I believe that this patch is needed: > >=20 > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kc= onfig > > index 8c03223..d025fd8 100644 > > --- a/drivers/platform/x86/Kconfig > > +++ b/drivers/platform/x86/Kconfig > > @@ -141,6 +141,7 @@ config DELL_SMO8800 > > config DELL_RBTN > > tristate "Dell Airplane Mode Switch driver" > > depends on ACPI > > + depends on INPUT > > depends on RFKILL > > ---help--- > > Say Y here if you want to support Dell Airplane Mode Switch ACP= I > >=20 > > I did not tested it yet, but all other drivers depends on INPUT. > >=20 >=20 > Acked-by: Randy Dunlap >=20 > Please get the patch merged. I was waiting on a new version from Pali, but it hasn't appeared quite = yet. I've dropped the dell-rbtn and associated dell-laptop changes from my next b= ranch for now to avoid the breakage. --=20 Darren Hart Intel Open Source Technology Center