* nfs commit breaks build for nfs4.1=y nfs4.2=n
@ 2015-06-25 14:55 Paul Gortmaker
2015-06-25 15:24 ` [next] nfs update breaks build on sparc Paul Gortmaker
2015-06-25 15:42 ` nfs commit breaks build for nfs4.1=y nfs4.2=n Peng Tao
0 siblings, 2 replies; 6+ messages in thread
From: Paul Gortmaker @ 2015-06-25 14:55 UTC (permalink / raw)
To: Peng Tao; +Cc: Jeff Layton, Trond Myklebust, linux-next
New breakage seen in linux-next:
fs/nfs/pnfs.c:2293: undefined reference to
`nfs42_proc_layoutstats_generic'
...bisected to:
commit 8733408d6ed713d080c325262d7b51a780136d41
Author: Peng Tao <tao.peng@primarydata.com>
Date: Tue Jun 23 19:51:57 2015 +0800
pnfs: add pnfs_report_layoutstat helper function
Probably caused by the unusual defconfig having:
$ grep NFS .config
CONFIG_KERNFS=y
CONFIG_NFS_FS=y
CONFIG_NFS_V2=y
CONFIG_NFS_V3=y
# CONFIG_NFS_V3_ACL is not set
CONFIG_NFS_V4=y
# CONFIG_NFS_SWAP is not set
CONFIG_NFS_V4_1=y <------------
# CONFIG_NFS_V4_2 is not set <------------
CONFIG_PNFS_FILE_LAYOUT=y
CONFIG_PNFS_FLEXFILE_LAYOUT=m
CONFIG_NFS_V4_1_IMPLEMENTATION_ID_DOMAIN="kernel.org"
# CONFIG_NFS_V4_1_MIGRATION is not set
CONFIG_ROOT_NFS=y
# CONFIG_NFS_USE_LEGACY_DNS is not set
CONFIG_NFS_USE_KERNEL_DNS=y
# CONFIG_NFSD is not set
CONFIG_NFS_COMMON=y
http://kisskb.ellerman.id.au/kisskb/buildresult/12449989/
^ permalink raw reply [flat|nested] 6+ messages in thread* [next] nfs update breaks build on sparc
2015-06-25 14:55 nfs commit breaks build for nfs4.1=y nfs4.2=n Paul Gortmaker
@ 2015-06-25 15:24 ` Paul Gortmaker
2015-06-25 22:40 ` Paul Gortmaker
2015-06-25 23:13 ` Trond Myklebust
2015-06-25 15:42 ` nfs commit breaks build for nfs4.1=y nfs4.2=n Peng Tao
1 sibling, 2 replies; 6+ messages in thread
From: Paul Gortmaker @ 2015-06-25 15:24 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-next, sparclinux
New breakage seen in linux-next today:
ERROR: "__xchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined!
ERROR: "__cmpxchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
I tried to reproduce it locally so I could run a bisect,
but it must be toolchain specific because I don't see it.
Paul.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [next] nfs update breaks build on sparc
2015-06-25 15:24 ` [next] nfs update breaks build on sparc Paul Gortmaker
@ 2015-06-25 22:40 ` Paul Gortmaker
2015-06-25 23:13 ` Trond Myklebust
1 sibling, 0 replies; 6+ messages in thread
From: Paul Gortmaker @ 2015-06-25 22:40 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-next@vger.kernel.org, sparclinux
On Thu, Jun 25, 2015 at 11:24 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
>
> New breakage seen in linux-next today:
>
> ERROR: "__xchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined!
> ERROR: "__cmpxchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
>
> I tried to reproduce it locally so I could run a bisect,
> but it must be toolchain specific because I don't see it.
Presumably this is the same thing; showing up in i386 and elsewhere:
fs/nfs/flexfilelayout/flexfilelayout.c:444:15: error: call to
'__xchg_wrong_size' declared with attribute error: Bad argument size
for xchg
fs/nfs/flexfilelayout/flexfilelayout.c:433:3: error: call to
'__cmpxchg_wrong_size' declared with attribute error: Bad argument
size for cmpxchg
fs/nfs/flexfilelayout/flexfilelayout.c:463:2: error: call to
'__cmpxchg_wrong_size' declared with attribute error: Bad argument
size for cmpxchg
fs/nfs/flexfilelayout/flexfilelayout.c:464:2: error: call to
'__cmpxchg_wrong_size' declared with attribute error: Bad argument
size for cmpxchg
make[4]: *** [fs/nfs/flexfilelayout/flexfilelayout.o] Error 1
make[3]: *** [fs/nfs/flexfilelayout] Error 2
make[2]: *** [fs/nfs] Error 2
http://kisskb.ellerman.id.au/kisskb/buildresult/12449737/
Paul.
---
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [next] nfs update breaks build on sparc
2015-06-25 15:24 ` [next] nfs update breaks build on sparc Paul Gortmaker
2015-06-25 22:40 ` Paul Gortmaker
@ 2015-06-25 23:13 ` Trond Myklebust
2015-06-26 1:13 ` Peng Tao
1 sibling, 1 reply; 6+ messages in thread
From: Trond Myklebust @ 2015-06-25 23:13 UTC (permalink / raw)
To: Paul Gortmaker, Tao Peng; +Cc: Linux Next Mailing List, sparclinux
On Thu, Jun 25, 2015 at 11:24 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
>
> New breakage seen in linux-next today:
>
> ERROR: "__xchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined!
> ERROR: "__cmpxchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
>
> I tried to reproduce it locally so I could run a bisect,
> but it must be toolchain specific because I don't see it.
>
Sigh. It looks as if xchg() and cmpxchg() are not available for 64-bit
integers on sparc32.
Tao, can we rely on mirror->lock to provide atomicity here instead?
Cheers
Trond
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [next] nfs update breaks build on sparc
2015-06-25 23:13 ` Trond Myklebust
@ 2015-06-26 1:13 ` Peng Tao
0 siblings, 0 replies; 6+ messages in thread
From: Peng Tao @ 2015-06-26 1:13 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Paul Gortmaker, Linux Next Mailing List, sparclinux
On Fri, Jun 26, 2015 at 7:13 AM, Trond Myklebust
<trond.myklebust@primarydata.com> wrote:
> On Thu, Jun 25, 2015 at 11:24 AM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>>
>> New breakage seen in linux-next today:
>>
>> ERROR: "__xchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined!
>> ERROR: "__cmpxchg_called_with_bad_pointer" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined!
>> make[2]: *** [__modpost] Error 1
>> make[1]: *** [modules] Error 2
>>
>> I tried to reproduce it locally so I could run a bisect,
>> but it must be toolchain specific because I don't see it.
>>
>
> Sigh. It looks as if xchg() and cmpxchg() are not available for 64-bit
> integers on sparc32.
> Tao, can we rely on mirror->lock to provide atomicity here instead?
>
yes, we can. It is already under mirror->lock. So we just need to open
code xchg/cmpxchg(). I'll send a patch to fix it.
Cheers,
Tao
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: nfs commit breaks build for nfs4.1=y nfs4.2=n
2015-06-25 14:55 nfs commit breaks build for nfs4.1=y nfs4.2=n Paul Gortmaker
2015-06-25 15:24 ` [next] nfs update breaks build on sparc Paul Gortmaker
@ 2015-06-25 15:42 ` Peng Tao
1 sibling, 0 replies; 6+ messages in thread
From: Peng Tao @ 2015-06-25 15:42 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Jeff Layton, Trond Myklebust, linux-next
Thanks Paul! It was reported by kbuild test robot and a fix has been
sent to linux-nfs list.
Cheers,
Tao
On Thu, Jun 25, 2015 at 10:55 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
>
> New breakage seen in linux-next:
>
> fs/nfs/pnfs.c:2293: undefined reference to
> `nfs42_proc_layoutstats_generic'
>
> ...bisected to:
>
> commit 8733408d6ed713d080c325262d7b51a780136d41
> Author: Peng Tao <tao.peng@primarydata.com>
> Date: Tue Jun 23 19:51:57 2015 +0800
>
> pnfs: add pnfs_report_layoutstat helper function
>
> Probably caused by the unusual defconfig having:
>
>
> $ grep NFS .config
> CONFIG_KERNFS=y
> CONFIG_NFS_FS=y
> CONFIG_NFS_V2=y
> CONFIG_NFS_V3=y
> # CONFIG_NFS_V3_ACL is not set
> CONFIG_NFS_V4=y
> # CONFIG_NFS_SWAP is not set
> CONFIG_NFS_V4_1=y <------------
> # CONFIG_NFS_V4_2 is not set <------------
> CONFIG_PNFS_FILE_LAYOUT=y
> CONFIG_PNFS_FLEXFILE_LAYOUT=m
> CONFIG_NFS_V4_1_IMPLEMENTATION_ID_DOMAIN="kernel.org"
> # CONFIG_NFS_V4_1_MIGRATION is not set
> CONFIG_ROOT_NFS=y
> # CONFIG_NFS_USE_LEGACY_DNS is not set
> CONFIG_NFS_USE_KERNEL_DNS=y
> # CONFIG_NFSD is not set
> CONFIG_NFS_COMMON=y
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12449989/
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-26 1:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-25 14:55 nfs commit breaks build for nfs4.1=y nfs4.2=n Paul Gortmaker
2015-06-25 15:24 ` [next] nfs update breaks build on sparc Paul Gortmaker
2015-06-25 22:40 ` Paul Gortmaker
2015-06-25 23:13 ` Trond Myklebust
2015-06-26 1:13 ` Peng Tao
2015-06-25 15:42 ` nfs commit breaks build for nfs4.1=y nfs4.2=n Peng Tao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).