linux-next: build warning in the origin tree

linux-next: build warning in the origin tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

Hi Linus,

Building the origin tree, today's linux-next build (powerpc allyesconfig)
produced this warning:

WARNING: mm/built-in.o(.text.unlikely+0xc22): Section mismatch in reference from the function .new_kmalloc_cache() to the variable .init.rodata:kmalloc_info
The function .new_kmalloc_cache() references
the variable __initconst kmalloc_info.
This is often because .new_kmalloc_cache lacks a __initconst 
annotation or the annotation of kmalloc_info is wrong.

Caused by commit a9730fca9946 ("Fix kmalloc slab creation sequence").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build warning in the origin tree

[Christoph Lameter]

On Tue, 30 Jun 2015, Stephen Rothwell wrote:

> WARNING: mm/built-in.o(.text.unlikely+0xc22): Section mismatch in reference from the function .new_kmalloc_cache() to the variable .init.rodata:kmalloc_info
> The function .new_kmalloc_cache() references
> the variable __initconst kmalloc_info.
> This is often because .new_kmalloc_cache lacks a __initconst
> annotation or the annotation of kmalloc_info is wrong.
>
> Caused by commit a9730fca9946 ("Fix kmalloc slab creation sequence").


Subject: Add __init attribute to new_kmalloc_cache

Signed-off-by: Christoph Lameter <cl@linux.com>

Index: linux/mm/slab_common.c
===================================================================
--- linux.orig/mm/slab_common.c
+++ linux/mm/slab_common.c
@@ -855,7 +855,7 @@ void __init setup_kmalloc_cache_index_ta
 	}
 }

-static void new_kmalloc_cache(int idx, unsigned long flags)
+static void __init new_kmalloc_cache(int idx, unsigned long flags)
 {
 	kmalloc_caches[idx] = create_kmalloc_cache(kmalloc_info[idx].name,
 					kmalloc_info[idx].size, flags);

Re: linux-next: build warning in the origin tree

[Geert Uytterhoeven]

On Tue, Jun 30, 2015 at 4:01 PM, Christoph Lameter <cl@linux.com> wrote:
> On Tue, 30 Jun 2015, Stephen Rothwell wrote:
>> WARNING: mm/built-in.o(.text.unlikely+0xc22): Section mismatch in reference from the function .new_kmalloc_cache() to the variable .init.rodata:kmalloc_info
>> The function .new_kmalloc_cache() references
>> the variable __initconst kmalloc_info.
>> This is often because .new_kmalloc_cache lacks a __initconst
>> annotation or the annotation of kmalloc_info is wrong.
>>
>> Caused by commit a9730fca9946 ("Fix kmalloc slab creation sequence").
>
>
> Subject: Add __init attribute to new_kmalloc_cache
>
> Signed-off-by: Christoph Lameter <cl@linux.com>

Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>

>
> Index: linux/mm/slab_common.c
> ===================================================================
> --- linux.orig/mm/slab_common.c
> +++ linux/mm/slab_common.c
> @@ -855,7 +855,7 @@ void __init setup_kmalloc_cache_index_ta
>         }
>  }
>
> -static void new_kmalloc_cache(int idx, unsigned long flags)
> +static void __init new_kmalloc_cache(int idx, unsigned long flags)
>  {
>         kmalloc_caches[idx] = create_kmalloc_cache(kmalloc_info[idx].name,
>                                         kmalloc_info[idx].size, flags);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds