linux-next: build failure after merge of the mailbox tree

linux-next: build failure after merge of the mailbox tree

[Stephen Rothwell]

Hi Jassi,

After merging the mailbox tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mailbox/mailbox-test.c: In function 'mbox_test_receive_message':
drivers/mailbox/mailbox-test.c:226:11: error: implicit declaration of function '__io_virt' [-Werror=implicit-function-declaration]
           __io_virt(tdev->mmio), MBOX_MAX_MSG_LEN, true);
           ^

Caused by commit

  a133f8b65d59 ("mailbox: mailbox-test: Correctly repair Sparse warnings")

I have used the mailbox tree from next-20151022 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build failure after merge of the mailbox tree

[Jassi Brar]

On 1 November 2015 at 17:42, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Jassi,
>
> After merging the mailbox tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/mailbox/mailbox-test.c: In function 'mbox_test_receive_message':
> drivers/mailbox/mailbox-test.c:226:11: error: implicit declaration of function '__io_virt' [-Werror=implicit-function-declaration]
>            __io_virt(tdev->mmio), MBOX_MAX_MSG_LEN, true);
>            ^
>
> Caused by commit
>
>   a133f8b65d59 ("mailbox: mailbox-test: Correctly repair Sparse warnings")
>
> I have used the mailbox tree from next-20151022 for today.
>
Lee, would you please send a fix for your last fix please?

Thanks.

Re: linux-next: build failure after merge of the mailbox tree

[Lee Jones]

On Wed, 04 Nov 2015, Jassi Brar wrote:

> On 1 November 2015 at 17:42, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi Jassi,
> >
> > After merging the mailbox tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/mailbox/mailbox-test.c: In function 'mbox_test_receive_message':
> > drivers/mailbox/mailbox-test.c:226:11: error: implicit declaration of function '__io_virt' [-Werror=implicit-function-declaration]
> >            __io_virt(tdev->mmio), MBOX_MAX_MSG_LEN, true);
> >            ^
> >
> > Caused by commit
> >
> >   a133f8b65d59 ("mailbox: mailbox-test: Correctly repair Sparse warnings")
> >
> > I have used the mailbox tree from next-20151022 for today.
> >
> Lee, would you please send a fix for your last fix please?

I was about to take a look at this, but it looks like you fixed it already.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

linux-next: build failure after merge of the mailbox tree

[Stephen Rothwell]

Hi Jassi,

After merging the mailbox tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from /home/sfr/next/next/include/linux/kvm_host.h:20:0,
                 from /home/sfr/next/next/arch/powerpc/kernel/asm-offsets.c:54:
/home/sfr/next/next/include/linux/msi.h:195:21: fatal error: asm/msi.h: No such file or directory

Caused by commit

  dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager")

Not all architectures have the above include file.

I have added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 29 Mar 2017 16:11:14 +1100
Subject: [PATCH] mailbox: do not compile test the Broadcom FlexRM Mailbox
 driver

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mailbox/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index 0b6f25e26c7c..ee1a3d9147ef 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -154,7 +154,7 @@ config BCM_PDC_MBOX
 
 config BCM_FLEXRM_MBOX
 	tristate "Broadcom FlexRM Mailbox"
-	depends on ARM64 || COMPILE_TEST
+	depends on ARM64
 	depends on HAS_DMA
 	select GENERIC_MSI_IRQ_DOMAIN
 	default ARCH_BCM_IPROC
-- 
2.11.0

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the mailbox tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

After merging the mailbox tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "pm_system_irq_wakeup" [drivers/mailbox/imx-mailbox.ko] undefined!

Caused by commit

  fd9d6d7ba81c ("mailbox: imx: Add support for identifying SCU wakeup source from sysfs")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the mailbox tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Hi all,

After merging the mailbox tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c: In function 'mdp_probe':
drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:297:41: error: implicit declaration of function 'cmdq_get_shift_pa' [-Wimplicit-function-declaration]
  297 |                 mdp->cmdq_shift_pa[i] = cmdq_get_shift_pa(mdp->cmdq_clt[i]->chan);
      |                                         ^~~~~~~~~~~~~~~~~

Caused by commit

  1f808916c0a6 ("mailbox: mtk-cmdq: Remove unsued cmdq_get_shift_pa()")

I have used the mailbox tree from next-20250526 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the mailbox tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

Hi all,

After merging the mailbox tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mailbox/mtk-tinysys-mailbox.c: In function 'mtk_tinysys_mhu_mbox_startup':
drivers/mailbox/mtk-tinysys-mailbox.c:95:9: error: implicit declaration of function 'irq_clear_status_flags' [-Wimplicit-function-declaration]
   95 |         irq_clear_status_flags(priv->irq, IRQ_NOAUTOEN);
      |         ^~~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/mtk-tinysys-mailbox.c:95:43: error: 'IRQ_NOAUTOEN' undeclared (first use in this function); did you mean 'IRQF_NO_AUTOEN'?
   95 |         irq_clear_status_flags(priv->irq, IRQ_NOAUTOEN);
      |                                           ^~~~~~~~~~~~
      |                                           IRQF_NO_AUTOEN
drivers/mailbox/mtk-tinysys-mailbox.c:95:43: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  43a9f5ab3d17 ("mailbox: Add MediaTek TinySYS MHU-like Mailbox")

Forgot to include linux/irq.h ...

I have used the mailbox tree from next-20250718 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the mailbox tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

Hi all,

After merging the mailbox tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

/tmp/next/build/drivers/mailbox/mailbox.c: In function 'fw_mbox_index_xlate':
/tmp/next/build/drivers/mailbox/mailbox.c:494:15: error: 'const struct fwnode_reference_args' has no member named 'args_count'
  494 |         if (sp->args_count < 1 || ind >= mbox->num_chans)
      |               ^~
make[5]: *** [/tmp/next/build/scripts/Makefile.build:287: drivers/mailbox/mailbox.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [/tmp/next/build/scripts/Makefile.build:556: drivers/mailbox] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [/tmp/next/build/scripts/Makefile.build:556: drivers] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/tmp/next/build/Makefile:2011: .] Error 2
make[1]: *** [/tmp/next/build/Makefile:248: __sub-make] Error 2
make: *** [Makefile:248: __sub-make] Error 2
Command exited with non-zero status 2
2388.97user 520.10system 0:21.52elapsed 13514%CPU (0avgtext+0avgdata 323276maxresident)k
0inputs+0outputs (1008major+37863234minor)pagefaults 0swaps

Caused by commit

  c889daa5a773 ("mailbox: Prevent out-of-bounds access in of_mbox_index_xlate()")

I have used the version from 20251003 instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the mailbox tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]

Hi all,

After merging the mailbox tree, today's linux-next build (arm64
defconfig) failed like this:

/tmp/next/build/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c: In function 'mdp_probe':
/tmp/next/build/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:297:41: error: implicit declaration of function 'cmdq_get_shift_pa' [-Wimplicit-function-declaration]
  297 |                 mdp->cmdq_shift_pa[i] = cmdq_get_shift_pa(mdp->cmdq_clt[i]->chan);
      |                                         ^~~~~~~~~~~~~~~~~
make[8]: *** [/tmp/next/build/scripts/Makefile.build:287: drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.o] Error 1
make[7]: *** [/tmp/next/build/scripts/Makefile.build:556: drivers/media/platform/mediatek/mdp3] Error 2
make[7]: *** Waiting for unfinished jobs....
make[6]: *** [/tmp/next/build/scripts/Makefile.build:556: drivers/media/platform/mediatek] Error 2
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [/tmp/next/build/scripts/Makefile.build:556: drivers/media/platform] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [/tmp/next/build/scripts/Makefile.build:556: drivers/media] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [/tmp/next/build/scripts/Makefile.build:556: drivers] Error 2
make[2]: *** [/tmp/next/build/Makefile:2011: .] Error 2
make[1]: *** [/tmp/next/build/Makefile:248: __sub-make] Error 2
make: *** [Makefile:248: __sub-make] Error 2
Command exited with non-zero status 2
18.77user 674.76system 0:08.77elapsed 7908%CPU (0avgtext+0avgdata 173604maxresident)k
0inputs+0outputs (6major+965196minor)pagefaults 0swaps

Caused by commit

  58e172b23fe2f ("mailbox: mtk-cmdq: Remove unused cmdq_get_shift_pa()")

I have used the version from 20251006 instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the mailbox tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Hi all,

After merging the mailbox tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c: In function 'mdp_probe':
drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:311:41: error: implicit declaration of function 'cmdq_get_shift_pa' [-Wimplicit-function-declaration]
  311 |                 mdp->cmdq_shift_pa[i] = cmdq_get_shift_pa(mdp->cmdq_clt[i]->chan);
      |                                         ^~~~~~~~~~~~~~~~~

Caused by commit

  e1fe978a07c7 ("mailbox: mtk-cmdq: Remove unsued cmdq_get_shift_pa()")

I have used the mailbox tree from next-20251210 for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the mailbox tree

[Jassi Brar]

On Wed, Dec 10, 2025 at 5:49 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the mailbox tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c: In function 'mdp_probe':
> drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:311:41: error: implicit declaration of function 'cmdq_get_shift_pa' [-Wimplicit-function-declaration]
>   311 |                 mdp->cmdq_shift_pa[i] = cmdq_get_shift_pa(mdp->cmdq_clt[i]->chan);
>       |                                         ^~~~~~~~~~~~~~~~~
>
> Caused by commit
>
>   e1fe978a07c7 ("mailbox: mtk-cmdq: Remove unsued cmdq_get_shift_pa()")
>
Jason, isn't your "Remove shift_pa from CMDQ jump functions" patchset
picked already?
Ideally this patch should have gone in that patchset. But if that pr
will be merged soon, maybe I can hold off mine. Otherwise, I will drop
this patch.

thanks
-Jassi

Re: linux-next: build failure after merge of the mailbox tree

[Jason-JH Lin (林睿祥)]

On Wed, 2025-12-10 at 18:01 -0600, Jassi Brar wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Wed, Dec 10, 2025 at 5:49 PM Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > 
> > Hi all,
> > 
> > After merging the mailbox tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c: In function
> > 'mdp_probe':
> > drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:311:41: error:
> > implicit declaration of function 'cmdq_get_shift_pa' [-Wimplicit-
> > function-declaration]
> >   311 |                 mdp->cmdq_shift_pa[i] =
> > cmdq_get_shift_pa(mdp->cmdq_clt[i]->chan);
> >       |                                         ^~~~~~~~~~~~~~~~~
> > 
> > Caused by commit
> > 
> >   e1fe978a07c7 ("mailbox: mtk-cmdq: Remove unsued
> > cmdq_get_shift_pa()")
> > 

Hi Jassi,

> Jason, isn't your "Remove shift_pa from CMDQ jump functions" patchset
> picked already?

No, soc, drm and mdp3 maintainers have not picked the patches before
this patch.

> Ideally this patch should have gone in that patchset. But if that pr
> will be merged soon, maybe I can hold off mine. Otherwise, I will
> drop
> this patch.

Please apply this patch, after all previous series have been applied in
order.
Series application order:
1. [Fixes] Refine DMA address handling for the command buffer
https://lore.kernel.org/all/20251022171847.379470-1-jason-jh.lin@mediatek.com/
2. [Series 1/4] Add GCE support for MT8196 and update CMDQ APIs
https://lore.kernel.org/all/20251031155838.1650833-1-jason-jh.lin@mediatek.com/
3. [Series 2/4] Migrate subsystems to new CMDQ APIs
https://lore.kernel.org/all/20251031160309.1654761-1-jason-jh.lin@mediatek.com/
4. [Series 3/4] Remove shift_pa from CMDQ jump functions
https://lore.kernel.org/all/20251031160712.1657810-1-jason-jh.lin@mediatek.com/
5. [Series 4/4] Remove deprecated CMDQ APIs (***this patch's series***)

Thanks!

---

Hi Angelo, CK, Nicolas,

Can you help to apply the patches before this one and send the pull
request soon?
Or are we plan to apply them later and drop this patch for now?

Regards,
Jason-JH.Lin

> 
> thanks
> -Jassi