From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH v2 2/3] device property: the secondary fwnode needs to depend on the primary Date: Tue, 29 Dec 2015 10:40:21 +0200 Message-ID: <20151229084020.GA19870@kuha.fi.intel.com> References: <1450877684-76316-1-git-send-email-andriy.shevchenko@linux.intel.com> <1450877684-76316-3-git-send-email-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga03.intel.com ([134.134.136.65]:58489 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbbL2Imf (ORCPT ); Tue, 29 Dec 2015 03:42:35 -0500 Content-Disposition: inline In-Reply-To: <1450877684-76316-3-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Andy Shevchenko Cc: Stephen Rothwell , linux-next@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Hi Andy, Found a bug from my code.. > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 0b22c8a..6c04d18 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -218,7 +218,7 @@ bool fwnode_property_present(struct fwnode_handle *fwnode, const char *propname) > bool ret; > > ret = __fwnode_property_present(fwnode, propname); > - if (ret == false && fwnode->secondary) > + if (ret == false && fwnode && fwnode->secondary) > ret = __fwnode_property_present(fwnode->secondary, propname); > return ret; > } > @@ -423,7 +423,7 @@ EXPORT_SYMBOL_GPL(device_property_match_string); > int _ret_; \ > _ret_ = FWNODE_PROP_READ(_fwnode_, _propname_, _type_, _proptype_, \ > _val_, _nval_); \ > - if (_ret_ == -EINVAL && _fwnode_->secondary) \ > + if (_ret_ == -EINVAL && fwnode && _fwnode_->secondary) \ This should be .._fwnode_ && _fwnode_->secondary) > _ret_ = FWNODE_PROP_READ(_fwnode_->secondary, _propname_, _type_, \ > _proptype_, _val_, _nval_); \ > _ret_; \ Cheers, -- heikki