From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: arm qemu test failures due to 'driver-core: platform: probe of-devices only using list of compatibles' Date: Mon, 15 Feb 2016 10:14:06 +0100 Message-ID: <20160215091406.GE12289@pengutronix.de> References: <20160214165010.GA3189@roeck-us.net> <20160214195501.GA12289@pengutronix.de> <20160214200755.GB10826@n2100.arm.linux.org.uk> <20160215081750.GD12289@pengutronix.de> <20160215085818.GC10826@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:46370 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752241AbcBOJOb (ORCPT ); Mon, 15 Feb 2016 04:14:31 -0500 Content-Disposition: inline In-Reply-To: <20160215085818.GC10826@n2100.arm.linux.org.uk> Sender: linux-next-owner@vger.kernel.org List-ID: To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck Hello Russell, On Mon, Feb 15, 2016 at 08:58:18AM +0000, Russell King - ARM Linux wrot= e: > On Mon, Feb 15, 2016 at 09:17:50AM +0100, Uwe Kleine-K=F6nig wrote: > > On Sun, Feb 14, 2016 at 08:07:55PM +0000, Russell King - ARM Linux = wrote: > > > On Sun, Feb 14, 2016 at 08:55:01PM +0100, Uwe Kleine-K=F6nig wrot= e: > > > > So the unexpected abnormality here is that even though this dev= ice is > > > > instantiated by dt, the driver doesn't provide any compatibles. > > > > Either my expectation is wrong, then 67d02a1bbb33455 should be = reverted > > >=20 > > > Your expectation is wrong. AMBA primecell devices have hardware = IDs > > > and are matched to their drivers by those IDs. Just like PCI. > >=20 > > pci devices don't appear in dt, do they? I don't see the connection > > between amba devices and platform devices, see my other mail in thi= s > > thread for some more details. >=20 > They both have hardware IDs, and they are both matched via those hard= ware > IDs. I changed platform_match which is about matching by dt compatible, acpi and/or device name. I don't see how this can affect an amba device give= n they match to a driver by a hardware id. > Your change has introduced a regression and is therefore wrong. I'd like to understand though why and how my commit is wrong to be able to fix it instead of getting it reverted. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |