From: Ingo Molnar <mingo@kernel.org>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com,
sfr@canb.auug.org.au, akpm@linux-foundation.org,
tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com,
peterz@infradead.org, linux-next@vger.kernel.org, deller@gmx.de
Subject: Re: [PATCH] [v4] x86, pkeys: fix siginfo ABI breakage from new field
Date: Thu, 3 Mar 2016 16:41:04 +0100 [thread overview]
Message-ID: <20160303154104.GA18424@gmail.com> (raw)
In-Reply-To: <20160301125451.02C7426D@viggo.jf.intel.com>
* Dave Hansen <dave@sr71.net> wrote:
> To fix this, we replace the u64 with an '__u32'. The __u32 is guaranteed to
> union well with the pointers from _addr_bnd. It is also plenty large enough to
> store the 16-bit pkey we have today on x86.
The 'union well' sentence is really a leftover from the earlier changelog (the
problem was never about interaction between union members) - a better explantion
is:
> To fix this, we replace the u64 with an '__u32'. The __u32 does not change the
> minimum alignment requirements of the structure and it is also plenty large
> enough to store the 16-bit pkey we have today on x86.
I fixed this up locally, no need to resend.
Thanks,
Ingo
prev parent reply other threads:[~2016-03-03 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 12:54 [PATCH] [v4] x86, pkeys: fix siginfo ABI breakage from new field Dave Hansen
2016-03-03 15:41 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303154104.GA18424@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=deller@gmx.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).