linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jacek Anaszewski <j.anaszewski@samsung.com>,
	Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Subject: linux-next: manual merge of the leds tree with the nand tree
Date: Thu, 14 Apr 2016 12:44:27 +1000	[thread overview]
Message-ID: <20160414124427.26e4e6ab@canb.auug.org.au> (raw)

Hi Jacek,

Today's linux-next merge of the leds tree got a conflict in:

  drivers/mtd/nand/nand_base.c

between commit:

  4d66dc858ec9 ("mtd: nand: implement the default mtd_ooblayout_ops")

from the nand tree and commit:

  4c7e054f0882 ("mtd: nand: Remove the "nand-disk" LED trigger")

from the leds tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/mtd/nand/nand_base.c
index 46c46642c24b,8d6287ef3926..000000000000
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@@ -48,102 -47,54 +47,96 @@@
  #include <linux/mtd/partitions.h>
  #include <linux/of_mtd.h>
  
 +static int nand_get_device(struct mtd_info *mtd, int new_state);
 +
 +static int nand_do_write_oob(struct mtd_info *mtd, loff_t to,
 +			     struct mtd_oob_ops *ops);
 +
- /*
-  * For devices which display every fart in the system on a separate LED. Is
-  * compiled away when LED support is disabled.
-  */
- DEFINE_LED_TRIGGER(nand_led_trigger);
- 
  /* Define default oob placement schemes for large and small page devices */
 -static struct nand_ecclayout nand_oob_8 = {
 -	.eccbytes = 3,
 -	.eccpos = {0, 1, 2},
 -	.oobfree = {
 -		{.offset = 3,
 -		 .length = 2},
 -		{.offset = 6,
 -		 .length = 2} }
 -};
 +static int nand_ooblayout_ecc_sp(struct mtd_info *mtd, int section,
 +				 struct mtd_oob_region *oobregion)
 +{
 +	struct nand_chip *chip = mtd_to_nand(mtd);
 +	struct nand_ecc_ctrl *ecc = &chip->ecc;
  
 -static struct nand_ecclayout nand_oob_16 = {
 -	.eccbytes = 6,
 -	.eccpos = {0, 1, 2, 3, 6, 7},
 -	.oobfree = {
 -		{.offset = 8,
 -		 . length = 8} }
 -};
 +	if (section > 1)
 +		return -ERANGE;
  
 -static struct nand_ecclayout nand_oob_64 = {
 -	.eccbytes = 24,
 -	.eccpos = {
 -		   40, 41, 42, 43, 44, 45, 46, 47,
 -		   48, 49, 50, 51, 52, 53, 54, 55,
 -		   56, 57, 58, 59, 60, 61, 62, 63},
 -	.oobfree = {
 -		{.offset = 2,
 -		 .length = 38} }
 -};
 +	if (!section) {
 +		oobregion->offset = 0;
 +		oobregion->length = 4;
 +	} else {
 +		oobregion->offset = 6;
 +		oobregion->length = ecc->total - 4;
 +	}
 +
 +	return 0;
 +}
 +
 +static int nand_ooblayout_free_sp(struct mtd_info *mtd, int section,
 +				  struct mtd_oob_region *oobregion)
 +{
 +	if (section > 1)
 +		return -ERANGE;
  
 -static struct nand_ecclayout nand_oob_128 = {
 -	.eccbytes = 48,
 -	.eccpos = {
 -		   80, 81, 82, 83, 84, 85, 86, 87,
 -		   88, 89, 90, 91, 92, 93, 94, 95,
 -		   96, 97, 98, 99, 100, 101, 102, 103,
 -		   104, 105, 106, 107, 108, 109, 110, 111,
 -		   112, 113, 114, 115, 116, 117, 118, 119,
 -		   120, 121, 122, 123, 124, 125, 126, 127},
 -	.oobfree = {
 -		{.offset = 2,
 -		 .length = 78} }
 +	if (mtd->oobsize == 16) {
 +		if (section)
 +			return -ERANGE;
 +
 +		oobregion->length = 8;
 +		oobregion->offset = 8;
 +	} else {
 +		oobregion->length = 2;
 +		if (!section)
 +			oobregion->offset = 3;
 +		else
 +			oobregion->offset = 6;
 +	}
 +
 +	return 0;
 +}
 +
 +const struct mtd_ooblayout_ops nand_ooblayout_sp_ops = {
 +	.ecc = nand_ooblayout_ecc_sp,
 +	.free = nand_ooblayout_free_sp,
  };
 +EXPORT_SYMBOL_GPL(nand_ooblayout_sp_ops);
  
 -static int nand_get_device(struct mtd_info *mtd, int new_state);
 +static int nand_ooblayout_ecc_lp(struct mtd_info *mtd, int section,
 +				 struct mtd_oob_region *oobregion)
 +{
 +	struct nand_chip *chip = mtd_to_nand(mtd);
 +	struct nand_ecc_ctrl *ecc = &chip->ecc;
  
 -static int nand_do_write_oob(struct mtd_info *mtd, loff_t to,
 -			     struct mtd_oob_ops *ops);
 +	if (section)
 +		return -ERANGE;
 +
 +	oobregion->length = ecc->total;
 +	oobregion->offset = mtd->oobsize - oobregion->length;
 +
 +	return 0;
 +}
 +
 +static int nand_ooblayout_free_lp(struct mtd_info *mtd, int section,
 +				  struct mtd_oob_region *oobregion)
 +{
 +	struct nand_chip *chip = mtd_to_nand(mtd);
 +	struct nand_ecc_ctrl *ecc = &chip->ecc;
 +
 +	if (section)
 +		return -ERANGE;
 +
 +	oobregion->length = mtd->oobsize - ecc->total - 2;
 +	oobregion->offset = 2;
 +
 +	return 0;
 +}
 +
 +const struct mtd_ooblayout_ops nand_ooblayout_lp_ops = {
 +	.ecc = nand_ooblayout_ecc_lp,
 +	.free = nand_ooblayout_free_lp,
 +};
 +EXPORT_SYMBOL_GPL(nand_ooblayout_lp_ops);
  
  static int check_offs_len(struct mtd_info *mtd,
  					loff_t ofs, uint64_t len)

             reply	other threads:[~2016-04-14  2:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14  2:44 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-04-14  2:41 linux-next: manual merge of the leds tree with the nand tree Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160414124427.26e4e6ab@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=boris.brezillon@free-electrons.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=j.anaszewski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).