linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiong Zhou <xzhou@redhat.com>
To: David Drysdale <drysdale@google.com>, hch@lst.de
Cc: Xiong Zhou <xzhou@redhat.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	axboe@fb.com, linux-next@vger.kernel.org,
	linux-nvdimm@ml01.01.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-next/linux memleak after IO on dax mountpoint
Date: Fri, 3 Jun 2016 14:35:14 +0800	[thread overview]
Message-ID: <20160603063514.GA16231@dhcp12-144.nay.redhat.com> (raw)
In-Reply-To: <CAHse=S-H_yMhZKNmMZpb41M+o+2tMRyxiUG9wQoemewBXXYTPw@mail.gmail.com>

On Thu, Jun 02, 2016 at 04:22:37PM +0100, David Drysdale wrote:
> On Sat, May 28, 2016 at 5:05 AM, Xiong Zhou <xzhou@redhat.com> wrote:
> > On Fri, May 27, 2016 at 04:46:17PM +0800, Xiong Zhou wrote:
> > ...
> >> Still working on to id which commit in this merge causes this issuer,
> >
> > Narrowed down to:
> >
> > 37e5823 block: add offset in blk_add_request_payload()
...
> > 0bf77e9 nvme: switch to RCU freeing the namespace
> > 9082e87 block: remove struct bio_batch
> 
> FWIW, I'm also seeing kmemleak report a leak with v4.7-rc1, in
> a different scenario (just normal desktop use).  Not done much
> digging so far, but this commit (9082e87bf) looks like it might be
> relevant

<snip..>

Thanks for the tip, accelerated my searching in the block merge.

On top of v4.7-rc1 , in order to revert this commit cleanly:

	9082e87 block: remove struct bio_batch

, have to revert these two:

	bbd848e0f block: reinstate early return of -EOPNOTSUPP from blkdev_issue_discard
	38f2525 block: add __blkdev_issue_discard

, then have to revert these two dependances:

202bae5 dm thin: unroll issue_discard() to create longer discard bio chains
3dba53a9 dm thin: use __blkdev_issue_discard for async discard support

With all these five commits reverted, NO memleak happens.

Reverting other four commits while not reverting 9082e87, memleak
happens.

Thanks,
Xiong

  reply	other threads:[~2016-06-03  6:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27  8:46 linux-next memleak after IO on dax mountpoint Xiong Zhou
2016-05-28  4:05 ` Xiong Zhou
2016-06-01 14:37   ` Jeff Moyer
2016-06-02  2:20     ` Xiong Zhou
2016-06-02 15:22   ` David Drysdale
2016-06-03  6:35     ` Xiong Zhou [this message]
2016-06-03 16:48     ` Bart Van Assche
2016-06-07 10:26       ` linux-next/linux " Xiong Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160603063514.GA16231@dhcp12-144.nay.redhat.com \
    --to=xzhou@redhat.com \
    --cc=axboe@fb.com \
    --cc=drysdale@google.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).