Re: linux-next: bad commit in the sunxi tree

Michael Ellerman
2016-10-31T02:59:58Z

Maxime Ripard <maxime.ripard@free-electrons.com> writes:
> On Thu, Oct 27, 2016 at 10:42:25AM +1100, Stephen Rothwell wrote:
>> On Tue, 25 Oct 2016 11:44:09 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>> > On Tue, Oct 25, 2016 at 09:22:55AM +1100, Stephen Rothwell wrote:
>> > > In today's sunxi tree
>> > > (git://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git#sunxi/for-next)
>> > > I noticed that commit
>> > >
>> > > 3861b711f8b5 ("ARM: sun5i: chip: add a node for the w1 gpio controller")
>> > >
>> > > has no Signed-off-by from its committer.
>> >
>> > Thanks, this has been fixed.
>> >
>> > Just out of curiosity, what command do you run to catch this?
>>
>> None :-) I look at the differences in each tree as I fetch it and
>> just happen to notice some of these sometimes. I should have a git
>> hook to check that there is a Signed-off-by for the author and
>> committer, but I would have to invest some time to figure out how :-)
>
> Ok, that's actually the real question I had in mind, if you had a hook
> I could use in order to avoid that kind of things in the future :)

I don't run a hook, but I have a separate script which does checks like
that. I've pulled out the Signed-off-by check into a script below, which
might work for you, or at least give you something to start from.

cheers

#!/bin/bash

function check_sob_by_committer
{
local commit=$1

git rev-parse --verify ${commit}^2 > /dev/null 2>&1
if [[ $? -eq 0 ]]; then
# It has at least 2 parents, ie. it's a merge
# We don't sign off merges, so we're done
return
fi

committer=$(git log -1 --format='%cn <%ce>' $commit)

git log -1 --format=%b $commit | grep "Signed-off-by: $committer" > /dev/null
if [[ $? -ne 0 ]]; then
echo " Not SOB committer '$committer'"
return 1
fi

return 0
}

check_sob_by_committer $1
exit $?