public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Kees Cook <keescook@chromium.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joel Fernandes <joelaf@google.com>
Subject: linux-next: build warning after merge of the pstore tree
Date: Wed, 16 Nov 2016 11:27:49 +1100	[thread overview]
Message-ID: <20161116112749.061f7424@canb.auug.org.au> (raw)

Hi Kees,

After merging the pstore tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/rcupdate.h:38:0,
                 from include/linux/idr.h:18,
                 from include/linux/kernfs.h:14,
                 from include/linux/sysfs.h:15,
                 from include/linux/kobject.h:21,
                 from include/linux/device.h:17,
                 from fs/pstore/ram_core.c:17:
fs/pstore/ram_core.c: In function 'buffer_size_add':
include/linux/spinlock.h:246:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
   _raw_spin_unlock_irqrestore(lock, flags); \
   ^
fs/pstore/ram_core.c:78:16: note: 'flags' was declared here
  unsigned long flags;
                ^
In file included from include/linux/rcupdate.h:38:0,
                 from include/linux/idr.h:18,
                 from include/linux/kernfs.h:14,
                 from include/linux/sysfs.h:15,
                 from include/linux/kobject.h:21,
                 from include/linux/device.h:17,
                 from fs/pstore/ram_core.c:17:
fs/pstore/ram_core.c: In function 'buffer_start_add':
include/linux/spinlock.h:246:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
   _raw_spin_unlock_irqrestore(lock, flags); \
   ^
fs/pstore/ram_core.c:56:16: note: 'flags' was declared here
  unsigned long flags;
                ^

Introduced by commit

  95937ddce59a ("pstore: Allow prz to control need for locking")

They appear to be a very noisy false positives. :-(

-- 
Cheers,
Stephen Rothwell

             reply	other threads:[~2016-11-16  0:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16  0:27 Stephen Rothwell [this message]
2016-11-16  0:35 ` linux-next: build warning after merge of the pstore tree Kees Cook
2016-11-16  5:19   ` Joel Fernandes
  -- strict thread matches above, loose matches on Subject: below --
2021-06-15 10:15 Stephen Rothwell
2021-06-15 15:36 ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161116112749.061f7424@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=joelaf@google.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox