From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] serial: st-asc: Use new GPIOD API to obtain RTS pin Date: Mon, 13 Feb 2017 09:59:18 +0000 Message-ID: <20170213095918.cwae537cmqtcofco@dell> References: <20170208161113.1b597c01@canb.auug.org.au> <20170208092425.azqkx3nwf4jhsfz5@dell> <20170208130039.GA28327@kroah.com> <20170209082150.m7u53pxz6evt5ckh@dell> <20170209085137.GA25944@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wr0-f171.google.com ([209.85.128.171]:33770 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751844AbdBMJ7W (ORCPT ); Mon, 13 Feb 2017 04:59:22 -0500 Received: by mail-wr0-f171.google.com with SMTP id i10so146877394wrb.0 for ; Mon, 13 Feb 2017 01:59:22 -0800 (PST) Content-Disposition: inline In-Reply-To: <20170209085137.GA25944@kroah.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Greg KH Cc: Stephen Rothwell , Linus Walleij , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Boris Brezillon , Alexander Stein , Andy Shevchenko On Thu, 09 Feb 2017, Greg KH wrote: > On Thu, Feb 09, 2017 at 08:21:50AM +0000, Lee Jones wrote: > > On Wed, 08 Feb 2017, Greg KH wrote: > > > > > On Wed, Feb 08, 2017 at 09:24:25AM +0000, Lee Jones wrote: > > > > The commits mentioned below adapt the GPIO API to allow more information > > > > to be passed directly through devm_get_gpiod_from_child() in the first > > > > instance. This facilitates the removal of subsequent calls, such as > > > > gpiod_direction_output(). This patch firstly moves to utilise the new > > > > API and secondly removes the now superfluous call do set the direction. > > > > > > > > Fixes: a264d10ff45c ("gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO") > > > > Fixes: b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request") > > > > Fixes: 4b0947974e59 ("gpio: Rename devm_get_gpiod_from_child()") > > > > Reported-by: Stephen Rothwell > > > > Suggested-by: Boris Brezillon > > > > Signed-off-by: Lee Jones > > > > --- > > > > drivers/tty/serial/st-asc.c | 11 ++++++----- > > > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c > > > > index bcf1d33..c334bcc 100644 > > > > --- a/drivers/tty/serial/st-asc.c > > > > +++ b/drivers/tty/serial/st-asc.c > > > > @@ -575,12 +575,13 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios, > > > > pinctrl_select_state(ascport->pinctrl, > > > > ascport->states[NO_HW_FLOWCTRL]); > > > > > > > > - gpiod = devm_get_gpiod_from_child(port->dev, "rts", > > > > - &np->fwnode); > > > > - if (!IS_ERR(gpiod)) { > > > > - gpiod_direction_output(gpiod, 0); > > > > + gpiod = devm_fwnode_get_gpiod_from_child(port->dev, > > > > + "rts", > > > > + &np->fwnode, > > > > + GPIOD_OUT_LOW, > > > > + np->name); > > > > > > I can't apply this :( > > > > > > Usually, when you move apis around, you add it, then convert it, wait a > > > kernel release, then remove the old one. That allows for issues like > > > this when new code is added in one maintainer's branch but not yours. > > > > > > So how about reverting your "drop the function" patch and then wait for > > > -rc2 to really remove it? > > > > I assume this is a question for LinusW? > > It's for whom ever is causing this breakage by removing an api in this > manner. +1 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog