* [PATCH v3] staging: greybus: loop_backtest: fixed consistent spacing style issue
@ 2017-03-01 10:09 Jonathan Bowie
2017-03-01 10:16 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Bowie @ 2017-03-01 10:09 UTC (permalink / raw)
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman; +Cc: greybus-dev, linux-next
Fixed incosistent spacing around arithmetic operator.
Signed-off-by: Jonathan Bowie <eudjtb@gmail.com>
---
drivers/staging/greybus/tools/loopback_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
index 18d7a3d..d5bb8d2 100644
--- a/drivers/staging/greybus/tools/loopback_test.c
+++ b/drivers/staging/greybus/tools/loopback_test.c
@@ -476,7 +476,7 @@ int format_output(struct loopback_test *t,
r->gbphy_firmware_latency_jitter);
} else {
- len += snprintf(&buf[len], buf_len- len, ",%s,%s,%u,%u,%u",
+ len += snprintf(&buf[len], buf_len - len, ",%s,%s,%u,%u,%u",
t->test_name, dev_name, t->size, t->iteration_max,
r->error);
--
2.7.4
v2
-tried to fix summary and commit message
v3
-actually fixed summary and commit message
-CCed staging mailing list
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] staging: greybus: loop_backtest: fixed consistent spacing style issue
2017-03-01 10:09 [PATCH v3] staging: greybus: loop_backtest: fixed consistent spacing style issue Jonathan Bowie
@ 2017-03-01 10:16 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2017-03-01 10:16 UTC (permalink / raw)
To: Jonathan Bowie
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev,
linux-next
On Wed, Mar 01, 2017 at 02:09:43AM -0800, Jonathan Bowie wrote:
> Fixed incosistent spacing around arithmetic operator.
>
> Signed-off-by: Jonathan Bowie <eudjtb@gmail.com>
> ---
This looks good except that you now dropped the changelog again (what
changed in v2 and v3?), and you CC:d the linux-next rather than the
staging list devel@driverdev.osuosl.org (I included the address in my
response to v1).
You can use scripts/get_maintainer.pl on a patch to figure out which
parties and lists to CC (you don't need to include LKML in this case).
Since you're doing this to learn the process, you can send a v4 and get
everything right.
Thanks,
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-01 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-01 10:09 [PATCH v3] staging: greybus: loop_backtest: fixed consistent spacing style issue Jonathan Bowie
2017-03-01 10:16 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox