From: Cyril Bur <cyrilbur@gmail.com>
To: greg@kroah.com
Cc: openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
joel@jms.id.au, benh@kernel.crashing.org, sfr@canb.auug.org.au,
linux-next@vger.kernel.org
Subject: [PATCH] drivers/misc: Aspeed LPC control fix format string warning
Date: Thu, 23 Mar 2017 15:29:05 +1100 [thread overview]
Message-ID: <20170323042905.10354-1-cyrilbur@gmail.com> (raw)
resource_size_t is a derivative of phys_addr_t and should also be
printed with %pap:
drivers/misc/aspeed-lpc-ctrl.c:232:17: warning: format '%x' expects
argument of type 'unsigned int', but argument 4 has type
'resource_size_t {aka long long unsigned int}' [-Wformat=] dev_info(dev,
"Loaded at %pap (0x%08x)\n",
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
---
drivers/misc/aspeed-lpc-ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c
index c654651a7b6d..2f6bb2244be5 100644
--- a/drivers/misc/aspeed-lpc-ctrl.c
+++ b/drivers/misc/aspeed-lpc-ctrl.c
@@ -229,8 +229,8 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev)
if (rc)
dev_err(dev, "Unable to register device\n");
else
- dev_info(dev, "Loaded at %pap (0x%08x)\n",
- &lpc_ctrl->mem_base, lpc_ctrl->mem_size);
+ dev_info(dev, "Loaded at %pap (%pap)\n",
+ &lpc_ctrl->mem_base, &lpc_ctrl->mem_size);
return rc;
}
--
2.12.1
reply other threads:[~2017-03-23 4:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323042905.10354-1-cyrilbur@gmail.com \
--to=cyrilbur@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).