From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Luis.Oliveira@synopsys.com,
linux-next <linux-next@vger.kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH v1] i2c: Provide a stub for i2c_detect_slave_mode()
Date: Sat, 8 Jul 2017 21:55:45 +0200 [thread overview]
Message-ID: <20170708195545.az4vgxqptrtdjv54@ninjato> (raw)
In-Reply-To: <20170706172617.39817-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
On Thu, Jul 06, 2017 at 08:26:17PM +0300, Andy Shevchenko wrote:
> Drivers would like to call i2c_detect_slave_mode() even if !I2C_SLAVE.
> Give them what they want to,
>
> Otherwise kernel will not compile:
> drivers/i2c/busses/i2c-designware-platdrv.c: In function ‘dw_i2c_plat_probe’:
> drivers/i2c/busses/i2c-designware-platdrv.c:331:6: error: implicit declaration of function ‘i2c_detect_slave_mode’ [-Werror=implicit-function-declaration]
> if (i2c_detect_slave_mode(&pdev->dev))
> ^~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Fixes: 6e38cf3b4421 ("i2c: designware: Let slave adapter support be optional")
> Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I'll apply it and push out. Buildbot found this issue as well and should
give me a success report...
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-07-08 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 17:26 [PATCH v1] i2c: Provide a stub for i2c_detect_slave_mode() Andy Shevchenko
2017-07-08 19:55 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170708195545.az4vgxqptrtdjv54@ninjato \
--to=wsa@the-dreams.de \
--cc=Luis.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox