Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

Darren Hart
2019-02-23T17:52:07Z

On Sun, Feb 24, 2019 at 01:19:25AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 9bfe33ba29d0 ("x86/CPU: Add Icelake model number")
>
> is missing a Signed-off-by from its committer.
>

Hi Stephen,

Apologies if I've asked you this before... I didn't find it after some
searching.

We should be catching errors like this before they hit next. First,
there is no reason we can't catch them - unlike the integration failures
only next can catch. Second, once they are in next, there is no "right"
way to fix them. Either rebase or send the bad patch to mainline - both
are bad. Don't get me wrong, I'm glad next catches them.... but I'd like
to get to the point where it doesn't trigger on our subsystem :-)

Are your patch mechanics tests available for us to integrate into our
commit and prepublication checks?

Thanks,

--
Darren Hart
VMware Open Source Technology Center