linux-next: build warning after merge of the drm-msm tree

linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

Hi all,

After merging the drm-msm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/msm/adreno/a5xx_gpu.c: In function 'a5xx_zap_shader_init':
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:493:19: warning: unused variable 'a5xx_gpu' [-Wunused-variable]
  struct a5xx_gpu *a5xx_gpu = to_a5xx_gpu(adreno_gpu);
                   ^

Introduced by commit

  8d6f08272b6f ("drm/msm: Remove uneeded platform dev members")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

Hi all,

After merging the drm-msm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from drivers/gpu/drm/msm/msm_drv.h:37:0,
                 from drivers/gpu/drm/msm/msm_gpu.h:24,
                 from drivers/gpu/drm/msm/msm_gpu.c:18:
drivers/gpu/drm/msm/msm_gpu.c: In function 'msm_gpu_init':
drivers/gpu/drm/msm/msm_gpu.c:742:31: warning: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'unsigned int' [-Wformat=]
   DRM_DEV_INFO_ONCE(drm->dev, "Only creating %lu ringbuffers\n",
                               ^
include/drm/drmP.h:208:60: note: in definition of macro 'DRM_DEV_INFO'
  drm_dev_printk(dev, KERN_INFO, DRM_UT_NONE, __func__, "", fmt, \
                                                            ^
drivers/gpu/drm/msm/msm_gpu.c:742:3: note: in expansion of macro 'DRM_DEV_INFO_ONCE'
   DRM_DEV_INFO_ONCE(drm->dev, "Only creating %lu ringbuffers\n",
   ^

Introduced by commit

  c2fceabca6d5 ("drm/msm: Support multiple ringbuffers")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

Hi Rob,

After merging the drm-msm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/drm/drm_mm.h:49:0,
                 from include/drm/drmP.h:73,
                 from drivers/gpu/drm/msm/msm_drv.h:37,
                 from drivers/gpu/drm/msm/msm_gpu.h:24,
                 from drivers/gpu/drm/msm/msm_gpu.c:18:
drivers/gpu/drm/msm/msm_gpu.c: In function 'msm_gpu_init':
drivers/gpu/drm/msm/msm_gpu.c:780:31: warning: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'unsigned int' [-Wformat=]
   DRM_DEV_INFO_ONCE(drm->dev, "Only creating %lu ringbuffers\n",
                               ^
include/drm/drm_print.h:237:60: note: in definition of macro 'DRM_DEV_INFO'
  drm_dev_printk(dev, KERN_INFO, DRM_UT_NONE, __func__, "", fmt, \
                                                            ^
drivers/gpu/drm/msm/msm_gpu.c:780:3: note: in expansion of macro 'DRM_DEV_INFO_ONCE'
   DRM_DEV_INFO_ONCE(drm->dev, "Only creating %lu ringbuffers\n",
   ^

Introduced by commit

  f97decac5f4c ("drm/msm: Support multiple ringbuffers")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the drm-msm tree

[Rob Clark]

On Tue, Oct 31, 2017 at 11:46 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Rob,
>
> After merging the drm-msm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/drm/drm_mm.h:49:0,
>                  from include/drm/drmP.h:73,
>                  from drivers/gpu/drm/msm/msm_drv.h:37,
>                  from drivers/gpu/drm/msm/msm_gpu.h:24,
>                  from drivers/gpu/drm/msm/msm_gpu.c:18:
> drivers/gpu/drm/msm/msm_gpu.c: In function 'msm_gpu_init':
> drivers/gpu/drm/msm/msm_gpu.c:780:31: warning: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'unsigned int' [-Wformat=]
>    DRM_DEV_INFO_ONCE(drm->dev, "Only creating %lu ringbuffers\n",
>                                ^
> include/drm/drm_print.h:237:60: note: in definition of macro 'DRM_DEV_INFO'
>   drm_dev_printk(dev, KERN_INFO, DRM_UT_NONE, __func__, "", fmt, \
>                                                             ^
> drivers/gpu/drm/msm/msm_gpu.c:780:3: note: in expansion of macro 'DRM_DEV_INFO_ONCE'
>    DRM_DEV_INFO_ONCE(drm->dev, "Only creating %lu ringbuffers\n",
>    ^
>
> Introduced by commit
>
>   f97decac5f4c ("drm/msm: Support multiple ringbuffers")

Oh, I thought Arnd fixed[1] that already, but it looks like I lost his
patch in the process of moving to a newer version of the
multiple-ringbuffers patch.

I've added Arnd's patch to msm-next.


[1] https://patchwork.freedesktop.org/patch/170111/

linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

Hi all,

After merging the drm-msm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c: In function 'msm_dsi_pll_7nm_init':
drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c:882:19: warning: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '5000000000' to '705032704' [-Woverflow]
  882 |   pll->max_rate = 5000000000UL;
      |                   ^~~~~~~~~~~~

Introduced by commit

  1ef7c99d145c ("drm/msm/dsi: add support for 7nm DSI PHY/PLL")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

Hi all,

On Mon, 14 Sep 2020 12:10:22 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm-msm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c: In function 'msm_dsi_pll_7nm_init':
> drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c:882:19: warning: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '5000000000' to '705032704' [-Woverflow]
>   882 |   pll->max_rate = 5000000000UL;
>       |                   ^~~~~~~~~~~~
> 
> Introduced by commit
> 
>   1ef7c99d145c ("drm/msm/dsi: add support for 7nm DSI PHY/PLL")

I am still getting this warning.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

Hi all,

After merging the drm-msm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/bitops.h:5,
                 from include/linux/kernel.h:12,
                 from include/linux/ascii85.h:11,
                 from drivers/gpu/drm/msm/adreno/adreno_gpu.c:9:
drivers/gpu/drm/msm/adreno/adreno_gpu.c: In function 'adreno_iommu_create_address_space':
include/linux/bits.h:36:11: warning: right shift count is negative [-Wshift-count-negative]
   36 |   (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
      |           ^~
include/linux/bits.h:38:31: note: in expansion of macro '__GENMASK'
   38 |  (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
      |                               ^~~~~~~~~
drivers/gpu/drm/msm/adreno/adreno_gpu.c:212:11: note: in expansion of macro 'GENMASK'
  212 |   start & GENMASK(48, 0), size);
      |           ^~~~~~~

Introduced by commit

  e3c64c7221f6 ("drm/msm: Set the global virtual address range from the IOMMU domain")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

Hi all,

After merging the drm-msm tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:235:18: warning: 'wb2_formats_rgb' defined but not used [-Wunused-const-variable=]
  235 | static const u32 wb2_formats_rgb[] = {
      |                  ^~~~~~~~~~~~~~~

Introduced by commit

  69d02730431e ("drm/msm/dpu: Support YUV formats on writeback for DPU 5.x+")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

Hi all,

On Fri, 7 Mar 2025 12:36:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm-msm tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:235:18: warning: 'wb2_formats_rgb' defined but not used [-Wunused-const-variable=]
>   235 | static const u32 wb2_formats_rgb[] = {
>       |                  ^~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   69d02730431e ("drm/msm/dpu: Support YUV formats on writeback for DPU 5.x+")

This became a build failure in the x86_64 allmodconfig build, so I have
used the drm-msm tree from next-20250306 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Hi all,

After merging the drm-msm tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/gpu/drm/msm/msm.o: warning: objtool: submit_lock_objects+0x43c: sibling call from callable instruction with modified stack frame

I don't know what introduced this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the drm-msm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

Hi all,

On Tue, 8 Jul 2025 14:44:09 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the drm-msm tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/gpu/drm/msm/msm.o: warning: objtool: submit_lock_objects+0x43c: sibling call from callable instruction with modified stack frame
> 
> I don't know what introduced this warning.

I am still seeing this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]