From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>, Felix Schnizlein <fschnizlein@suse.com>,
Borislav Petkov <bp@alien8.de>
Subject: Re: linux-next: Tree for Sep 19 (x86/kernel/cpuinfo.c)
Date: Tue, 26 Sep 2017 10:18:41 +0200 [thread overview]
Message-ID: <20170926081841.GA937@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1709260930220.1941@nanos>
On Tue, Sep 26, 2017 at 09:40:00AM +0200, Thomas Gleixner wrote:
> On Mon, 25 Sep 2017, Randy Dunlap wrote:
> > On 09/19/17 08:54, Randy Dunlap wrote:
> > > On 09/18/17 21:15, Stephen Rothwell wrote:
> > >> Hi all,
> > >>
> > >> Changes since 20170918:
> > >>
> > >> Linus' tree still had its build failure for which I reverted a commit.
> > >>
> > >
> > > on i386:
> > >
> > > ../arch/x86/kernel/cpuinfo.c: In function 'cpuinfo_flags':
>
> Where does this file come from? Random driver code added to arch/x86? This
> was neither acked nor reviewed by any x86 maintainer and just slapped into
> arch/x86/kernel/ without spending a split second of brain to find the spot
> where it actually belongs. It's not rocket science to figure that out.
It is arch specific, cpu specific to be specific :)
Where would you have this file go instead?
And these patches were posted many times, Felix, you did cc: the arch
maintainers, right? I don't have access to my archives at the moment...
And this isn't in Linus's tree, just linux-next for now, I don't see
what Linus's tree has to to with this report, but my coffee hasn't
kicked in yet.
thanks,
greg k-h
next prev parent reply other threads:[~2017-09-26 8:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 4:15 linux-next: Tree for Sep 19 Stephen Rothwell
2017-09-19 15:49 ` linux-next: Tree for Sep 19 (drivers/gpu/drm/i915/i915_gem.c) Randy Dunlap
2017-09-19 15:54 ` linux-next: Tree for Sep 19 (x86/kernel/cpuinfo.c) Randy Dunlap
2017-09-26 1:19 ` Randy Dunlap
2017-09-26 7:40 ` Thomas Gleixner
2017-09-26 8:18 ` Greg Kroah-Hartman [this message]
2017-09-26 10:40 ` Thomas Gleixner
2017-09-26 12:36 ` Felix Schnizlein
2017-09-26 16:00 ` Thomas Gleixner
2017-09-26 21:18 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926081841.GA937@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=fschnizlein@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).