From: Tony Lindgren <tony@atomide.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the omap tree
Date: Wed, 29 Nov 2017 08:50:50 -0800 [thread overview]
Message-ID: <20171129165050.GG28152@atomide.com> (raw)
In-Reply-To: <20171129093017.5e69ad0d@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> [171128 22:32]:
> Hi Tony,
>
> Commit
>
> 57af8b4f7b46 ("Revert "ARM: omap2plus: Run make savedefconfig again to save some space"")
>
> is missing a Signed-off-by from its author or committer.
>
> Also, it is nice to put some reasoning in the commit message for a revert
> so future you knows why you did it.
Thanks for letting me know, that's no longer in my for-next branch.
And yes, I should have added a proper commit message to the revert.
Regards,
Tony
next prev parent reply other threads:[~2017-11-29 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 22:30 linux-next: Signed-off-by missing for commit in the omap tree Stephen Rothwell
2017-11-29 16:50 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-02 21:41 Stephen Rothwell
2018-07-03 6:18 ` Tony Lindgren
2019-10-22 20:10 Stephen Rothwell
2019-10-23 14:47 ` Tony Lindgren
2024-11-03 20:51 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129165050.GG28152@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).